Attention is currently required from: Bora Guvendik, Cliff Huang, Jayvik Desai, Jérémy Compostella, Kyoung Il Kim, Paul Menzel, Pranava Y N, Subrata Banik, Wonkyu Kim.
Kapil Porwal has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/85200?usp=email )
Change subject: mb/google/fatcat: Add Intel Touch support for touchscreen and touchpad
......................................................................
Patch Set 38:
(3 comments)
File src/mainboard/google/fatcat/variants/fatcat/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/85200/comment/b2e169b3_6488eccb?usp... :
PS38, Line 374: register "wake_gpe" = "GPE0_DW0_11"
Can be removed now.
File src/mainboard/google/fatcat/variants/fatcat/variant.c:
https://review.coreboot.org/c/coreboot/+/85200/comment/36f25d53_405f9274?usp... :
PS38, Line 50: config->pmc_gpe0_dw0 = GPP_VGPIO
same.
https://review.coreboot.org/c/coreboot/+/85200/comment/086649f6_2c2185d1?usp... :
PS38, Line 54: config->pmc_gpe0_dw0 = GPP_VGPIO;
You can remove this now.
FYI, GPP_VGPIO3 (COMM3) is not same as GPP_VGPIO (COMM5).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85200?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I865dbb9eed648c8f35c7f469b27a13be993ff479
Gerrit-Change-Number: 85200
Gerrit-PatchSet: 38
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Kyoung Il Kim
kyoung.il.kim@intel.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kyoung Il Kim
kyoung.il.kim@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Wed, 02 Apr 2025 20:57:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No