Attention is currently required from: Lance Zhao, Anjaneya "Reddy" Chagam, David Hendricks, Stefan Reinauer, Angel Pons.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52863 )
Change subject: inteltool: add initial suppot for Sapphire Rapids Scalable Processor
......................................................................
Patch Set 1:
(2 comments)
File util/inteltool/inteltool.h:
https://review.coreboot.org/c/coreboot/+/52863/comment/2c784cad_f17eea36
PS1, Line 302:
One tab too many?
Ack
File util/inteltool/inteltool.c:
https://review.coreboot.org/c/coreboot/+/52863/comment/57916fdd_84de6096
PS1, Line 146: Sacalable
typo: S*calable
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52863
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf492d6e7993b9d55d6cd865e721c81876cee9a4
Gerrit-Change-Number: 52863
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 07 May 2021 21:21:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment