Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46800 )
Change subject: util/docker: Update coreboot-sdk to set python2 as default ......................................................................
util/docker: Update coreboot-sdk to set python2 as default
Even though both python2 and python3 are now installed to the SDK, the default python program is not. This sets the default to python2.
Signed-off-by: Martin Roth martin@coreboot.org Change-Id: I4220c316df86cb2481143a79fadb70fc734e6879 --- M util/docker/coreboot-sdk/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/46800/1
diff --git a/util/docker/coreboot-sdk/Dockerfile b/util/docker/coreboot-sdk/Dockerfile index 749b543..0ae63c8 100644 --- a/util/docker/coreboot-sdk/Dockerfile +++ b/util/docker/coreboot-sdk/Dockerfile @@ -79,6 +79,7 @@ xz-utils \ zlib1g-dev \ && apt-get clean \ + && update-alternatives --install /usr/bin/python python /usr/bin/python2 1 \ && ln -s /usr/bin/automake /usr/bin/automake-1.15 \ && ln -s /usr/bin/aclocal /usr/bin/aclocal-1.15
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46800 )
Change subject: util/docker: Update coreboot-sdk to set python2 as default ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46800 )
Change subject: util/docker: Update coreboot-sdk to set python2 as default ......................................................................
util/docker: Update coreboot-sdk to set python2 as default
Even though both python2 and python3 are now installed to the SDK, the default python program is not. This sets the default to python2.
Signed-off-by: Martin Roth martin@coreboot.org Change-Id: I4220c316df86cb2481143a79fadb70fc734e6879 Reviewed-on: https://review.coreboot.org/c/coreboot/+/46800 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M util/docker/coreboot-sdk/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/util/docker/coreboot-sdk/Dockerfile b/util/docker/coreboot-sdk/Dockerfile index 749b543..0ae63c8 100644 --- a/util/docker/coreboot-sdk/Dockerfile +++ b/util/docker/coreboot-sdk/Dockerfile @@ -79,6 +79,7 @@ xz-utils \ zlib1g-dev \ && apt-get clean \ + && update-alternatives --install /usr/bin/python python /usr/bin/python2 1 \ && ln -s /usr/bin/automake /usr/bin/automake-1.15 \ && ln -s /usr/bin/aclocal /usr/bin/aclocal-1.15
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46800 )
Change subject: util/docker: Update coreboot-sdk to set python2 as default ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 5/1/6 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/25267 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/25266 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/25265 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/25264 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/25262 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/25261
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Martin Roth (Code Review)
-
Patrick Georgi (Code Review)