Change in coreboot[master]: soc/intel/common/block/lpc: Drop unnecessary helper function

[Subrata Banik (Code Review)]

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38952 )

Change subject: soc/intel/common/block/lpc: Drop unnecessary helper function
......................................................................

soc/intel/common/block/lpc: Drop unnecessary helper function

This patch removes unnecessary helper function pch_lpc_interrupt_init()
and directly making use of soc_pch_pirq_init() function to avoid redundent
device NULL check.

TEST=Able to build and boot CML platform.

Change-Id: I3d11afb7e98f9b7f84beb2fdf308bbffeb3bbff7
Signed-off-by: Subrata Banik 
---
M src/soc/intel/common/block/lpc/lpc_lib.c
1 file changed, 1 insertion(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/38952/1

diff --git a/src/soc/intel/common/block/lpc/lpc_lib.c b/src/soc/intel/common/block/lpc/lpc_lib.c
index 3ad2176..5b30a81 100644
--- a/src/soc/intel/common/block/lpc/lpc_lib.c
+++ b/src/soc/intel/common/block/lpc/lpc_lib.c
@@ -270,17 +270,6 @@
    		gen_io_dec[i]);
 }

-static void pch_lpc_interrupt_init(void)
-{
-	const struct device *dev;
-
-	dev = pcidev_on_root(PCH_DEV_SLOT_LPC, 0);
-	if (!dev)
-		return;
-
-	soc_pch_pirq_init(dev);
-}
-
 void pch_enable_lpc(void)
 {
    /* Lookup device tree in romstage */
@@ -295,7 +284,7 @@
    lpc_set_gen_decode_range(gen_io_dec);
    soc_setup_dmi_pcr_io_dec(gen_io_dec);
    if (ENV_PAYLOAD_LOADER)
-		pch_lpc_interrupt_init();
+		soc_pch_pirq_init(dev);
 }

void lpc_enable_pci_clk_cntl(void)

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38952 )

Change subject: soc/intel/common/block/lpc: Drop unnecessary helper function
......................................................................

Patch Set 1: Code-Review+2

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38952 )

Change subject: soc/intel/common/block/lpc: Drop unnecessary helper function
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/38952/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38952/1//COMMIT_MSG@10 
PS1, Line 10: redundent
redundant

[Subrata Banik (Code Review)]

Hello Werner Zeh, Pratikkumar V Prajapati, Patrick Rudolph, Angel Pons, Arthur Heymans, Aamir Bohra, Wonkyu Kim, V Sowmya, build bot (Jenkins), Nico Huber, Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38952

to look at the new patch set (#2).

Change subject: soc/intel/common/block/lpc: Drop unnecessary helper function
......................................................................

soc/intel/common/block/lpc: Drop unnecessary helper function

This patch removes unnecessary helper function pch_lpc_interrupt_init()
and directly making use of soc_pch_pirq_init() function to avoid redundant
device NULL check.

TEST=Able to build and boot CML platform.

Change-Id: I3d11afb7e98f9b7f84beb2fdf308bbffeb3bbff7
Signed-off-by: Subrata Banik 
---
M src/soc/intel/common/block/lpc/lpc_lib.c
1 file changed, 1 insertion(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/38952/2

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38952 )

Change subject: soc/intel/common/block/lpc: Drop unnecessary helper function
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38952/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38952/1//COMMIT_MSG@10 
PS1, Line 10: redundent
> redundant

Ack

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38952 )

Change subject: soc/intel/common/block/lpc: Drop unnecessary helper function
......................................................................

Patch Set 2: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38952 )

Change subject: soc/intel/common/block/lpc: Drop unnecessary helper function
......................................................................

Patch Set 2: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38952 )

Change subject: soc/intel/common/block/lpc: Drop unnecessary helper function
......................................................................

Patch Set 2: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/38952/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38952/2//COMMIT_MSG@10 
PS2, Line 10: making
makes

or

… and directly uses soc_pch_pirq_init() …

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38952 )

Change subject: soc/intel/common/block/lpc: Drop unnecessary helper function
......................................................................

Patch Set 2: Code-Review+2

[Subrata Banik (Code Review)]

Hello Patrick Rudolph, Angel Pons, Arthur Heymans, Aamir Bohra, Wonkyu Kim, Paul Menzel, build bot (Jenkins), Furquan Shaikh, Werner Zeh, Pratikkumar V Prajapati, V Sowmya, Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38952

to look at the new patch set (#3).

Change subject: soc/intel/common/block/lpc: Drop unnecessary helper function
......................................................................

soc/intel/common/block/lpc: Drop unnecessary helper function

This patch removes unnecessary helper function pch_lpc_interrupt_init()
and directly uses soc_pch_pirq_init() function to avoid redundant
device NULL check.

TEST=Able to build and boot CML platform.

Change-Id: I3d11afb7e98f9b7f84beb2fdf308bbffeb3bbff7
Signed-off-by: Subrata Banik 
---
M src/soc/intel/common/block/lpc/lpc_lib.c
1 file changed, 1 insertion(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/38952/3

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38952 )

Change subject: soc/intel/common/block/lpc: Drop unnecessary helper function
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38952/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38952/2//COMMIT_MSG@10 
PS2, Line 10: making
> makes […]

Ack

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38952 )

Change subject: soc/intel/common/block/lpc: Drop unnecessary helper function
......................................................................

soc/intel/common/block/lpc: Drop unnecessary helper function

This patch removes unnecessary helper function pch_lpc_interrupt_init()
and directly uses soc_pch_pirq_init() function to avoid redundant
device NULL check.

TEST=Able to build and boot CML platform.

Change-Id: I3d11afb7e98f9b7f84beb2fdf308bbffeb3bbff7
Signed-off-by: Subrata Banik 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38952
Reviewed-by: Werner Zeh 
Reviewed-by: Angel Pons 
Reviewed-by: Paul Menzel 
Reviewed-by: Nico Huber 
Reviewed-by: Aamir Bohra 
Tested-by: build bot (Jenkins) 
---
M src/soc/intel/common/block/lpc/lpc_lib.c
1 file changed, 1 insertion(+), 12 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve
  Werner Zeh: Looks good to me, approved
  Aamir Bohra: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/soc/intel/common/block/lpc/lpc_lib.c b/src/soc/intel/common/block/lpc/lpc_lib.c
index 3ad2176..5b30a81 100644
--- a/src/soc/intel/common/block/lpc/lpc_lib.c
+++ b/src/soc/intel/common/block/lpc/lpc_lib.c
@@ -270,17 +270,6 @@
    		gen_io_dec[i]);
 }

-static void pch_lpc_interrupt_init(void)
-{
-	const struct device *dev;
-
-	dev = pcidev_on_root(PCH_DEV_SLOT_LPC, 0);
-	if (!dev)
-		return;
-
-	soc_pch_pirq_init(dev);
-}
-
 void pch_enable_lpc(void)
 {
    /* Lookup device tree in romstage */
@@ -295,7 +284,7 @@
    lpc_set_gen_decode_range(gen_io_dec);
    soc_setup_dmi_pcr_io_dec(gen_io_dec);
    if (ENV_PAYLOAD_LOADER)
-		pch_lpc_interrupt_init();
+		soc_pch_pirq_init(dev);
 }

void lpc_enable_pci_clk_cntl(void)