Change in coreboot[master]: mb/{asus/p2b,supermicro/x10slm-f}/dsdt.asl: Reformat DefinitionBlock(...
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45791 )
Change subject: mb/{asus/p2b,supermicro/x10slm-f}/dsdt.asl: Reformat DefinitionBlock() and use macro ......................................................................
mb/{asus/p2b,supermicro/x10slm-f}/dsdt.asl: Reformat DefinitionBlock() and use macro
Change-Id: I28655280e6caebeae82ed881b7871f48699e4155 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/asus/p2b/dsdt.asl M src/mainboard/supermicro/x10slm-f/dsdt.asl 2 files changed, 16 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/45791/1
diff --git a/src/mainboard/asus/p2b/dsdt.asl b/src/mainboard/asus/p2b/dsdt.asl index e1bda17..19bdb61 100644 --- a/src/mainboard/asus/p2b/dsdt.asl +++ b/src/mainboard/asus/p2b/dsdt.asl @@ -9,7 +9,14 @@ #define SUPERIO_SHOW_LPT
#include <acpi/acpi.h> -DefinitionBlock ("DSDT.aml", "DSDT", 2, OEM_ID, ACPI_TABLE_CREATOR, 1) +DefinitionBlock ( + "DSDT.aml", + "DSDT", + CURRENT_DSDT_REV, + OEM_ID, + ACPI_TABLE_CREATOR, + 1 + ) { /* _SB scope defining the main processor is generated in SSDT. */
diff --git a/src/mainboard/supermicro/x10slm-f/dsdt.asl b/src/mainboard/supermicro/x10slm-f/dsdt.asl index fc0ca02..92d72a9 100644 --- a/src/mainboard/supermicro/x10slm-f/dsdt.asl +++ b/src/mainboard/supermicro/x10slm-f/dsdt.asl @@ -2,7 +2,14 @@
#include <acpi/acpi.h>
-DefinitionBlock("dsdt.aml", "DSDT", 2, OEM_ID, ACPI_TABLE_CREATOR, 0x20181220) +DefinitionBlock( + "dsdt.aml", + "DSDT", + CURRENT_DSDT_REV, + OEM_ID, + ACPI_TABLE_CREATOR, + 0x20181220 + ) { #include "acpi/platform.asl" #include <southbridge/intel/common/acpi/platform.asl>
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45791 )
Change subject: mb/{asus/p2b,supermicro/x10slm-f}/dsdt.asl: Reformat DefinitionBlock() and use macro ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/45791/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45791/1//COMMIT_MSG@7 PS1, Line 7: mb/{asus/p2b,supermicro/x10slm-f}/dsdt.asl: Reformat DefinitionBlock() and use macro Two commits for each change would be nice in the future.
Hello build bot (Jenkins), Tristan Corrick, Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45791
to look at the new patch set (#2).
Change subject: mb/{asus/p2b,supermicro/x10slm-f}/dsdt.asl: Reformat DefinitionBlock() and use macro ......................................................................
mb/{asus/p2b,supermicro/x10slm-f}/dsdt.asl: Reformat DefinitionBlock() and use macro
Change-Id: I28655280e6caebeae82ed881b7871f48699e4155 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/asus/p2b/dsdt.asl M src/mainboard/supermicro/x10slm-f/dsdt.asl 2 files changed, 16 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/45791/2
Hello build bot (Jenkins), Tristan Corrick, Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45791
to look at the new patch set (#3).
Change subject: mb/{asus/p2b,supermicro/x10slm-f}/dsdt.asl: Reformat DefinitionBlock() and use macro ......................................................................
mb/{asus/p2b,supermicro/x10slm-f}/dsdt.asl: Reformat DefinitionBlock() and use macro
Change-Id: I28655280e6caebeae82ed881b7871f48699e4155 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/asus/p2b/dsdt.asl M src/mainboard/supermicro/x10slm-f/dsdt.asl 2 files changed, 16 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/45791/3
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45791 )
Change subject: mb/{asus/p2b,supermicro/x10slm-f}/dsdt.asl: Reformat DefinitionBlock() and use macro ......................................................................
Patch Set 3: Code-Review+2
Hello build bot (Jenkins), Nico Huber, Tristan Corrick, Paul Menzel, Werner Zeh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45791
to look at the new patch set (#4).
Change subject: mb/{asus/p2b,supermicro/x10slm-f}/dsdt.asl: Reformat DefinitionBlock() ......................................................................
mb/{asus/p2b,supermicro/x10slm-f}/dsdt.asl: Reformat DefinitionBlock()
Change-Id: I28655280e6caebeae82ed881b7871f48699e4155 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/asus/p2b/dsdt.asl M src/mainboard/supermicro/x10slm-f/dsdt.asl 2 files changed, 16 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/45791/4
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45791 )
Change subject: mb/{asus/p2b,supermicro/x10slm-f}/dsdt.asl: Reformat DefinitionBlock() ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review) -
Paul Menzel (Code Review)
-
Werner Zeh (Code Review)