Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/58952 )
Change subject: soc/amd/*/include/smi: fix off-by-one in SCIMAPS defines ......................................................................
soc/amd/*/include/smi: fix off-by-one in SCIMAPS defines
SCIMAPS is the total number of SCI to GEVENT mappings. configure_scimap returns early when the scimap is greater or equal than SCIMAPS, so for SMITYPE_ACDC_TIMER it returned early without doing what was expected from it to do despite that being a valid value, so fix this off-by-one.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Ibaf8c5618ddbf0b8d4cd612a7f1347d8562bbfcb --- M src/soc/amd/cezanne/include/soc/smi.h M src/soc/amd/picasso/include/soc/smi.h M src/soc/amd/stoneyridge/include/soc/smi.h 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/58952/1
diff --git a/src/soc/amd/cezanne/include/soc/smi.h b/src/soc/amd/cezanne/include/soc/smi.h index dc299a5..f0948bb 100644 --- a/src/soc/amd/cezanne/include/soc/smi.h +++ b/src/soc/amd/cezanne/include/soc/smi.h @@ -6,7 +6,7 @@ #include <types.h>
#define SMI_GEVENTS 24 -#define SCIMAPS 58 +#define SCIMAPS 59 /* 0..58 */ #define SCI_GPES 32
#define SMI_EVENT_STATUS 0x0 diff --git a/src/soc/amd/picasso/include/soc/smi.h b/src/soc/amd/picasso/include/soc/smi.h index e86809e..8256b21 100644 --- a/src/soc/amd/picasso/include/soc/smi.h +++ b/src/soc/amd/picasso/include/soc/smi.h @@ -6,7 +6,7 @@ #include <types.h>
#define SMI_GEVENTS 24 -#define SCIMAPS 58 +#define SCIMAPS 59 /* 0..58 */ #define SCI_GPES 32
#define SMI_EVENT_STATUS 0x0 diff --git a/src/soc/amd/stoneyridge/include/soc/smi.h b/src/soc/amd/stoneyridge/include/soc/smi.h index 6162475..0e0bc37 100644 --- a/src/soc/amd/stoneyridge/include/soc/smi.h +++ b/src/soc/amd/stoneyridge/include/soc/smi.h @@ -4,7 +4,7 @@ #define AMD_STONEYRIDGE_SMI_H
#define SMI_GEVENTS 24 -#define SCIMAPS 58 +#define SCIMAPS 59 /* 0..58 */ #define SCI_GPES 32
#define SMI_EVENT_STATUS 0x0