[L] Change in coreboot[master]: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI

[Name of user not set (Code Review)]

Attention is currently required from: Patrick Rudolph, Christian Walter, Angel Pons, Lean Sheng Tan.

[e-mail] has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68137 )

Change subject: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI
......................................................................

Patch Set 4:

(8 comments)

Patchset:

PS1:
> Would be nice to make the build bot happy

in progress :)

Patchset:

PS2:
> Please use your real name in Gerrit.

Done

File src/mainboard/prodrive/atlas/emi.c:

https://review.coreboot.org/c/coreboot/+/68137/comment/180f484e_0d4d938c 
PS1, Line 15: #define EMI_1_BASE EMI_0_BASE + APPLICATION_ID + 0x1
> > Macros with complex values should be enclosed in parentheses […]

APPLICATION_ID is the last EMI runtime register (see page 223 of http://ww1.microchip.com/downloads/en/DeviceDoc/MEC152x-Data-Sheet-DS0000342...).

Each EMI instance (0 and 1) has its own set of runtime registers which are mapped at
address 0xc00. EMI-0's runtime registers are located at 0xc00-0xc0c and EMI-1's registers at 0xc0d-0xc19.

Therefore, EMI_1_BASE = EMI_0_BASE + APPLICATION_ID + 0x1

File src/mainboard/prodrive/atlas/vpd.h:

https://review.coreboot.org/c/coreboot/+/68137/comment/3517d2a2_3cee3729 
PS2, Line 3: #ifndef __VPD_H__
> It's a good idea to "namespace" include guards, to avoid funky issues when two different headers use […]

Done

https://review.coreboot.org/c/coreboot/+/68137/comment/f99f9ef5_117f85a0 
PS2, Line 6: #include <stddef.h>
> You use u16 and u8 below, so you'd need <stdint.h>. But you can just #include <types. […]

Done

https://review.coreboot.org/c/coreboot/+/68137/comment/bea6c0b5_ac00846a 
PS2, Line 24:  * */
> nit: Coding style says that these comments should end like this: […]

Done

https://review.coreboot.org/c/coreboot/+/68137/comment/d5900019_9872b4e5 
PS2, Line 32: extern
> We typically don't use `extern` in declarations inside a header.

Done

https://review.coreboot.org/c/coreboot/+/68137/comment/566d1626_a1379556 
PS2, Line 36:
> There are two trailing newlines, we only need one.

Done