Attention is currently required from: Patrick Rudolph, Christian Walter, Angel Pons, Lean Sheng Tan.
8 comments:
Patchset:
Would be nice to make the build bot happy
in progress :)
Patchset:
Please use your real name in Gerrit.
Done
File src/mainboard/prodrive/atlas/emi.c:
Patch Set #1, Line 15: #define EMI_1_BASE EMI_0_BASE + APPLICATION_ID + 0x1
> Macros with complex values should be enclosed in parentheses […]
APPLICATION_ID is the last EMI runtime register (see page 223 of http://ww1.microchip.com/downloads/en/DeviceDoc/MEC152x-Data-Sheet-DS00003427A.pdf).
Each EMI instance (0 and 1) has its own set of runtime registers which are mapped at
address 0xc00. EMI-0's runtime registers are located at 0xc00-0xc0c and EMI-1's registers at 0xc0d-0xc19.
Therefore, EMI_1_BASE = EMI_0_BASE + APPLICATION_ID + 0x1
File src/mainboard/prodrive/atlas/vpd.h:
Patch Set #2, Line 3: #ifndef __VPD_H__
It's a good idea to "namespace" include guards, to avoid funky issues when two different headers use […]
Done
Patch Set #2, Line 6: #include <stddef.h>
You use u16 and u8 below, so you'd need <stdint.h>. But you can just #include <types. […]
Done
nit: Coding style says that these comments should end like this: […]
Done
Patch Set #2, Line 32: extern
We typically don't use `extern` in declarations inside a header.
Done
There are two trailing newlines, we only need one.
Done
To view, visit change 68137. To unsubscribe, or for help writing mail filters, visit settings.