Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68416 )
Change subject: soc/intel/meteorlake: Add support to skip the MBP HOB ......................................................................
soc/intel/meteorlake: Add support to skip the MBP HOB
This patch adds the support to enable/disable skipping MBP HOB from the devicetree based on mainboard requirement. Porting the feature from commit 2bc54e7c001c ("soc/intel/alderlake: Add support to skip the MBP HOB")
TEST=Build and boot to verify that the right value has been passed to the FSP.
Signed-off-by: Wonkyu Kim wonkyu.kim@intel.com Change-Id: I360d33617b9d2626fce5600e861214b0747f57b4 Reviewed-on: https://review.coreboot.org/c/coreboot/+/68416 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Subrata Banik subratabanik@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Kapil Porwal kapilporwal@google.com --- M src/soc/intel/meteorlake/chip.h M src/soc/intel/meteorlake/romstage/fsp_params.c 2 files changed, 32 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Subrata Banik: Looks good to me, approved Kapil Porwal: Looks good to me, approved
diff --git a/src/soc/intel/meteorlake/chip.h b/src/soc/intel/meteorlake/chip.h index 1d335c5..b6e3ab2 100644 --- a/src/soc/intel/meteorlake/chip.h +++ b/src/soc/intel/meteorlake/chip.h @@ -325,6 +325,12 @@ * Default 0. */ uint8_t lan_clk; + + /* + * Enable or Disable Skipping MBP HOB. + * Default is set to 0 and set to 1 to skip the MBP HOB. + */ + bool skip_mbp_hob; };
typedef struct soc_intel_meteorlake_config config_t; diff --git a/src/soc/intel/meteorlake/romstage/fsp_params.c b/src/soc/intel/meteorlake/romstage/fsp_params.c index 60324e9..0ca3756 100644 --- a/src/soc/intel/meteorlake/romstage/fsp_params.c +++ b/src/soc/intel/meteorlake/romstage/fsp_params.c @@ -173,6 +173,9 @@
/* Skip GPIO configuration from FSP */ m_cfg->GpioOverride = 0x1; + + /* Skip MBP HOB */ + m_cfg->SkipMbpHob = config->skip_mbp_hob; }
static void fill_fspm_audio_params(FSP_M_CONFIG *m_cfg,