Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47660 )
Change subject: Doc/relnotes/4.13: Add details about resource allocator v4 ......................................................................
Doc/relnotes/4.13: Add details about resource allocator v4
This change adds details about the new resource allocator v4 in coreboot to the release notes for 4.13.
Change-Id: I7071bdf0faffda61fc5941886c963181939c07e3 Signed-off-by: Furquan Shaikh furquan@google.com --- M Documentation/releases/coreboot-4.13-relnotes.md 1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/47660/1
diff --git a/Documentation/releases/coreboot-4.13-relnotes.md b/Documentation/releases/coreboot-4.13-relnotes.md index 139fa20..1e9f707 100644 --- a/Documentation/releases/coreboot-4.13-relnotes.md +++ b/Documentation/releases/coreboot-4.13-relnotes.md @@ -88,4 +88,16 @@ It still needs changes in assembly, fixed integer to pointer conversions in C, wrappers for blobs, support for running Option ROMs, among other things.
+### Resource allocator v4 + +A new revision of resource allocator v4 is now added to coreboot that +supports mutiple ranges for allocating resources. Unlike the previous +allocator (v3), it does not use the topmost available window for +allocation. Instead, it uses the first window within the address space +that is available and satisfies the resource request. This allows +utilization of the entire available address space and also allows +allocation above the 4G boundary. The old resource allocator v3 is +still retained for some AMD platforms that do not conform to the +requirements of the allocator. + ### Add significant changes here
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47660 )
Change subject: Doc/relnotes/4.13: Add details about resource allocator v4 ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47660/2/Documentation/releases/core... File Documentation/releases/coreboot-4.13-relnotes.md:
https://review.coreboot.org/c/coreboot/+/47660/2/Documentation/releases/core... PS2, Line 99: The old resource allocator v3 is : still retained for some AMD platforms that do not conform to the : requirements of the allocator. Please add a deprecation notice for platforms still using allocator v3.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47660 )
Change subject: Doc/relnotes/4.13: Add details about resource allocator v4 ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47660/2/Documentation/releases/core... File Documentation/releases/coreboot-4.13-relnotes.md:
https://review.coreboot.org/c/coreboot/+/47660/2/Documentation/releases/core... PS2, Line 99: The old resource allocator v3 is : still retained for some AMD platforms that do not conform to the : requirements of the allocator.
Please add a deprecation notice for platforms still using allocator v3.
I don't really want to remove the affected platforms; rather, I'd like to stop having two allocators in the tree. Setting a deadline to complete the migration to v4 feels reasonable enough.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47660 )
Change subject: Doc/relnotes/4.13: Add details about resource allocator v4 ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47660/2/Documentation/releases/core... File Documentation/releases/coreboot-4.13-relnotes.md:
https://review.coreboot.org/c/coreboot/+/47660/2/Documentation/releases/core... PS2, Line 99: The old resource allocator v3 is : still retained for some AMD platforms that do not conform to the : requirements of the allocator.
I don't really want to remove the affected platforms; rather, I'd like to stop having two allocators […]
But wasn’t the porting effort for AMD AGESA platforms quite fundamental?
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47660 )
Change subject: Doc/relnotes/4.13: Add details about resource allocator v4 ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47660/2/Documentation/releases/core... File Documentation/releases/coreboot-4.13-relnotes.md:
https://review.coreboot.org/c/coreboot/+/47660/2/Documentation/releases/core... PS2, Line 99: The old resource allocator v3 is : still retained for some AMD platforms that do not conform to the : requirements of the allocator.
But wasn’t the porting effort for AMD AGESA platforms quite fundamental?
Yes, the changes required for the AMD platforms is going to be quite significant.
Angel - what is your recommendation for the deprecation notice?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47660 )
Change subject: Doc/relnotes/4.13: Add details about resource allocator v4 ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47660/2/Documentation/releases/core... File Documentation/releases/coreboot-4.13-relnotes.md:
https://review.coreboot.org/c/coreboot/+/47660/2/Documentation/releases/core... PS2, Line 99: The old resource allocator v3 is : still retained for some AMD platforms that do not conform to the : requirements of the allocator.
Yes, the changes required for the AMD platforms is going to be quite significant. […]
CB:47409 is going to get merged soon, so it's just a matter of adding another item in the deprecations section. Please make sure to add a list of affected chipsets.
There's usually six months to do something about announced deprecations before the actual removals, which would happen after coreboot 4.14 is out. Given that the point of this deprecation notice is *not* to drop the code if there's still interest in it, I'm going to be lenient and only do removals right after 4.14 when absolutely nothing was done about the deprecated platforms. I'm more than happy to give additional time to someone who's actually trying to improve these platforms. 😊
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47660 )
Change subject: Doc/relnotes/4.13: Add details about resource allocator v4 ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47660/2/Documentation/releases/core... File Documentation/releases/coreboot-4.13-relnotes.md:
https://review.coreboot.org/c/coreboot/+/47660/2/Documentation/releases/core... PS2, Line 99: The old resource allocator v3 is : still retained for some AMD platforms that do not conform to the : requirements of the allocator.
CB:47409 is going to get merged soon, so it's just a matter of adding another item in the deprecations section.
Okay, I can rebase on top of that.
Please make sure to add a list of affected chipsets.
Sounds good.
I'm more than happy to give additional time to someone who's actually trying to improve these platforms.
Sounds good. I can try to capture a summary of what you said in the deprecation notice.
Hello build bot (Jenkins), Paul Menzel, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47660
to look at the new patch set (#3).
Change subject: Doc/relnotes/4.13: Add details about resource allocator v4 ......................................................................
Doc/relnotes/4.13: Add details about resource allocator v4
This change adds details about the new resource allocator v4 in coreboot to the release notes for 4.13.
Change-Id: I7071bdf0faffda61fc5941886c963181939c07e3 Signed-off-by: Furquan Shaikh furquan@google.com --- M Documentation/releases/coreboot-4.13-relnotes.md 1 file changed, 33 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/47660/3
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47660 )
Change subject: Doc/relnotes/4.13: Add details about resource allocator v4 ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47660/2/Documentation/releases/core... File Documentation/releases/coreboot-4.13-relnotes.md:
https://review.coreboot.org/c/coreboot/+/47660/2/Documentation/releases/core... PS2, Line 99: The old resource allocator v3 is : still retained for some AMD platforms that do not conform to the : requirements of the allocator.
CB:47409 is going to get merged soon, so it's just a matter of adding another item in the deprecat […]
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47660 )
Change subject: Doc/relnotes/4.13: Add details about resource allocator v4 ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47660/3/Documentation/releases/core... File Documentation/releases/coreboot-4.13-relnotes.md:
https://review.coreboot.org/c/coreboot/+/47660/3/Documentation/releases/core... PS3, Line 118: ### Resource allocator v3 @Angel: If this seems too strong, I can reword it.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47660 )
Change subject: Doc/relnotes/4.13: Add details about resource allocator v4 ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47660/3/Documentation/releases/core... File Documentation/releases/coreboot-4.13-relnotes.md:
https://review.coreboot.org/c/coreboot/+/47660/3/Documentation/releases/core... PS3, Line 118: ### Resource allocator v3
@Angel: If this seems too strong, I can reword it.
Sounds good.
What I would do is reflow the paragraphs to make them more rectangular. This isn't code: while line length for running text should be between 72 to 80 characters, it is by no means a hard limit and I'd rather have a 84-character line on a mostly-rectangular paragraph over shorter lines where the right margin pretends to be a rollercoaster. 😄
https://review.coreboot.org/c/coreboot/+/47660/3/Documentation/releases/core... PS3, Line 121: the resource : allocator "the" resource allocator? I'd use "resource allocator v4" instead.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47660 )
Change subject: Doc/relnotes/4.13: Add details about resource allocator v4 ......................................................................
Patch Set 3: Code-Review+1
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47660 )
Change subject: Doc/relnotes/4.13: Add details about resource allocator v4 ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47660/3/Documentation/releases/core... File Documentation/releases/coreboot-4.13-relnotes.md:
https://review.coreboot.org/c/coreboot/+/47660/3/Documentation/releases/core... PS3, Line 121: the resource : allocator
"the" resource allocator? I'd use "resource allocator v4" instead.
Actually they are not the requirements for v4 allocator. They have always been the requirements of resource allocation in coreboot. Do you want me to put it as "resource allocation" instead?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47660 )
Change subject: Doc/relnotes/4.13: Add details about resource allocator v4 ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47660/3/Documentation/releases/core... File Documentation/releases/coreboot-4.13-relnotes.md:
https://review.coreboot.org/c/coreboot/+/47660/3/Documentation/releases/core... PS3, Line 121: the resource : allocator
Actually they are not the requirements for v4 allocator. […]
Ah, I recall: the v3 allocator handled such contract breaches better than v4. "resource allocation" should work, yes.
Hello build bot (Jenkins), Paul Menzel, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47660
to look at the new patch set (#4).
Change subject: Doc/relnotes/4.13: Add details about resource allocator v4 ......................................................................
Doc/relnotes/4.13: Add details about resource allocator v4
This change adds details about the new resource allocator v4 in coreboot to the release notes for 4.13.
Change-Id: I7071bdf0faffda61fc5941886c963181939c07e3 Signed-off-by: Furquan Shaikh furquan@google.com --- M Documentation/releases/coreboot-4.13-relnotes.md 1 file changed, 29 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/47660/4
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47660 )
Change subject: Doc/relnotes/4.13: Add details about resource allocator v4 ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47660/3/Documentation/releases/core... File Documentation/releases/coreboot-4.13-relnotes.md:
https://review.coreboot.org/c/coreboot/+/47660/3/Documentation/releases/core... PS3, Line 118: ### Resource allocator v3
Sounds good. […]
Done
https://review.coreboot.org/c/coreboot/+/47660/3/Documentation/releases/core... PS3, Line 121: the resource : allocator
Ah, I recall: the v3 allocator handled such contract breaches better than v4. […]
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47660 )
Change subject: Doc/relnotes/4.13: Add details about resource allocator v4 ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/47660/4/Documentation/releases/core... File Documentation/releases/coreboot-4.13-relnotes.md:
https://review.coreboot.org/c/coreboot/+/47660/4/Documentation/releases/core... PS4, Line 124: northbridge/amd/pi/00660F01 This is going to be removed in CB:47649 but I'll update the release notes should that change land into the release.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47660 )
Change subject: Doc/relnotes/4.13: Add details about resource allocator v4 ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47660/4/Documentation/releases/core... File Documentation/releases/coreboot-4.13-relnotes.md:
https://review.coreboot.org/c/coreboot/+/47660/4/Documentation/releases/core... PS4, Line 124: northbridge/amd/pi/00660F01
This is going to be removed in CB:47649 but I'll update the release notes should that change land in […]
SG. Thanks Angel!
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47660 )
Change subject: Doc/relnotes/4.13: Add details about resource allocator v4 ......................................................................
Patch Set 4:
Uh, needs a manual rebase :/
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47660 )
Change subject: Doc/relnotes/4.13: Add details about resource allocator v4 ......................................................................
Patch Set 4:
Oh, just Gerrit being silly.
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47660 )
Change subject: Doc/relnotes/4.13: Add details about resource allocator v4 ......................................................................
Doc/relnotes/4.13: Add details about resource allocator v4
This change adds details about the new resource allocator v4 in coreboot to the release notes for 4.13.
Change-Id: I7071bdf0faffda61fc5941886c963181939c07e3 Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47660 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M Documentation/releases/coreboot-4.13-relnotes.md 1 file changed, 29 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/Documentation/releases/coreboot-4.13-relnotes.md b/Documentation/releases/coreboot-4.13-relnotes.md index 7c7102b..8ce35da 100644 --- a/Documentation/releases/coreboot-4.13-relnotes.md +++ b/Documentation/releases/coreboot-4.13-relnotes.md @@ -122,6 +122,16 @@ console static ensures that we can see console output even if there's a bug in the more involved code to query options.
+### Resource allocator v4 + +A new revision of resource allocator v4 is now added to coreboot that supports +mutiple ranges for allocating resources. Unlike the previous allocator (v3), it does +not use the topmost available window for allocation. Instead, it uses the first +window within the address space that is available and satisfies the resource request. +This allows utilization of the entire available address space and also allows +allocation above the 4G boundary. The old resource allocator v3 is still retained for +some AMD platforms that do not conform to the requirements of the allocator. + ### Add significant changes here
Deprecations @@ -132,3 +142,22 @@ In order to minimize the usage of PCI bus mastering, the options we introduced in this release will be dropped in a future release again. For more details, please see [Preparations to minimize enabling PCI bus mastering](#preparations-to-minimize-enabling-pci-bus-mastering-in-coreboot). + +### Resource allocator v3 + +Resource allocator v3 is retained in coreboot tree because the following platforms +do not conform to the requirements of the resource allocation i.e. not all the fixed +resources of the platform are provided during the `read_resources()` operation: + +* northbridge/amd/pi/00630F01 +* northbridge/amd/pi/00730F01 +* northbridge/amd/pi/00660F01 +* northbridge/amd/agesa/family14 +* northbridge/amd/agesa/family15tn +* northbridge/amd/agesa/family16kb + +In order to have a single unified allocator in coreboot, this notice is being added +to ensure that the platforms listed above are fixed before the next release. If there +is interest in maintaining support for these platforms beyond the next release, +please ensure that the platforms are fixed to conform to the expectations of resource +allocation.
-
Angel Pons (Code Review) -
Furquan Shaikh (Code Review)
-
Paul Menzel (Code Review)