Attention is currently required from: Utkarsh Verma.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74170 )
Change subject: arch/x86/smbios: Fix file formatting ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74170/comment/15f241f9_74f9af6a PS2, Line 9: minor Not sure what "minor" is supposed to mean here.
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/74170/comment/5c181d99_839cba31 PS2, Line 216: dimm->serial[1], dimm->serial[2], dimm->serial[3]); It's a good idea to ask oneself whether the suggestions from automated tools make sense from a human perspective. Putting `dimm->serial[0]` on one line and the rest of `dimm->serial[x]` arguments on the next line is odd, especially consideringt that all four arguments could simply be together in one line.
TL;DR style "fixes" in coreboot tend to be frowned upon because people have different opinions.
https://review.coreboot.org/c/coreboot/+/74170/comment/d71b0e3d_40b54bc9 PS2, Line 378: : t->bios_characteristics = BIOS_CHARACTERISTICS_PCI_SUPPORTED : | BIOS_CHARACTERISTICS_SELECTABLE_BOOT : | BIOS_CHARACTERISTICS_UPGRADEABLE; This is not an improvement w.r.t. readability.
https://review.coreboot.org/c/coreboot/+/74170/comment/410baf8d_926f80a0 PS2, Line 1276: || device_type == SMBIOS_DEVICE_TYPE_UNKNOWN) What exactly is fixed here? Both conditions were nicely aligned before.