Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37394 )
Change subject: arch/x86/Kconfig: Move pagetables down by 4K ......................................................................
arch/x86/Kconfig: Move pagetables down by 4K
In case of 64K bootblock the pagetables doesn't fit, as the CBFS header also needs a few bytes.
Fixes build error on platforms that use 64KiB bootblock. Tested on Lenovo T410 with additional x86_64 patches.
Change-Id: I854c5f575e2376827a366cca8d25682c4d90bc8f Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/arch/x86/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/37394/1
diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig index 0e6f486..1e27970 100644 --- a/src/arch/x86/Kconfig +++ b/src/arch/x86/Kconfig @@ -68,7 +68,7 @@ config ARCH_X86_64_PGTBL_LOC hex "x86_64 page table location in CBFS" depends on ARCH_BOOTBLOCK_X86_64 - default 0xfffea000 + default 0xfffe9000 help The position where to place pagetables. Needs to be known at compile time. Must not overlap other files in CBFS.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37394 )
Change subject: arch/x86/Kconfig: Move pagetables down by 4K ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37394/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37394/4//COMMIT_MSG@9 PS4, Line 9: doesn't don't fit
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37394
to look at the new patch set (#5).
Change subject: arch/x86/Kconfig: Move pagetables down by 4K ......................................................................
arch/x86/Kconfig: Move pagetables down by 4K
In case of 64K bootblock the pagetables don't fit, as the CBFS header also needs a few bytes.
Fixes build error on platforms that use 64KiB bootblock. Tested on Lenovo T410 with additional x86_64 patches.
Change-Id: I854c5f575e2376827a366cca8d25682c4d90bc8f Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/arch/x86/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/37394/5
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37394 )
Change subject: arch/x86/Kconfig: Move pagetables down by 4K ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37394/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37394/4//COMMIT_MSG@9 PS4, Line 9: doesn't
don't fit
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37394 )
Change subject: arch/x86/Kconfig: Move pagetables down by 4K ......................................................................
Patch Set 5: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37394 )
Change subject: arch/x86/Kconfig: Move pagetables down by 4K ......................................................................
arch/x86/Kconfig: Move pagetables down by 4K
In case of 64K bootblock the pagetables don't fit, as the CBFS header also needs a few bytes.
Fixes build error on platforms that use 64KiB bootblock. Tested on Lenovo T410 with additional x86_64 patches.
Change-Id: I854c5f575e2376827a366cca8d25682c4d90bc8f Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37394 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/arch/x86/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig index 0346c71..900c9c1 100644 --- a/src/arch/x86/Kconfig +++ b/src/arch/x86/Kconfig @@ -69,7 +69,7 @@ config ARCH_X86_64_PGTBL_LOC hex "x86_64 page table location in CBFS" depends on ARCH_BOOTBLOCK_X86_64 - default 0xfffea000 + default 0xfffe9000 help The position where to place pagetables. Needs to be known at compile time. Must not overlap other files in CBFS.
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)