Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69703 )
Change subject: soc/intel/broadwell: Fix out() parameter order ......................................................................
soc/intel/broadwell: Fix out() parameter order
Change-Id: I0897acddd00bad89a5fd784f82380ed0d0d2c06e Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/69703 Reviewed-by: Elyes Haouas ehaouas@noos.fr Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/broadwell/pch/pmutil.c 1 file changed, 16 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved Arthur Heymans: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/broadwell/pch/pmutil.c b/src/soc/intel/broadwell/pch/pmutil.c index 59ae72f..3da6bce 100644 --- a/src/soc/intel/broadwell/pch/pmutil.c +++ b/src/soc/intel/broadwell/pch/pmutil.c @@ -309,7 +309,7 @@ void enable_tco_sci(void) { /* Clear pending events */ - outl(get_pmbase() + GPE0_STS(3), TCOSCI_STS); + outl(TCOSCI_STS, get_pmbase() + GPE0_STS(3));
/* Enable TCO SCI events */ enable_gpe(TCOSCI_EN);