Change in coreboot[4.11_branch]: mb/facebook/watson: select VPD_SMBIOS_VERSION

[Jonathan Zhang (Code Review)]

Jonathan Zhang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42942 )

Change subject: mb/facebook/watson: select VPD_SMBIOS_VERSION
......................................................................

mb/facebook/watson: select VPD_SMBIOS_VERSION

Select VPD, GENERATE_SMBIOS_TABLES, VPD_SMBIOS_VERSION so that
"firmware_version" key value in RO_VPD is reported in smbios type
0 as BIOS version.

TEST=Build coreboot image for WatsonV2, run "vpd -s
firmware_version=FB_OSF_1.2 -i RO_VPD -f build/coreboot.rom"
command to add firmware_version key value pair in RO_VPD,
flash the image to WatsonV2 and reboot it, run dmidecode to verify:

[root@localhost ~]# dmidecode -t 0
...
BIOS Information
    Vendor: coreboot
    Version: FB_OSF_1.2
...

Signed-off-by: Jonathan Zhang 
Change-Id: Id559904bfc0afec0668cfaa28303242da4fccf5c

temp

Change-Id: I31fb2cef01161175a0c01094c5445f7fa340f2d0
---
M src/mainboard/facebook/watson/Kconfig
1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/42942/1

diff --git a/src/mainboard/facebook/watson/Kconfig b/src/mainboard/facebook/watson/Kconfig
index f8f93df..2ebc020 100644
--- a/src/mainboard/facebook/watson/Kconfig
+++ b/src/mainboard/facebook/watson/Kconfig
@@ -12,6 +12,7 @@
    def_bool y
    select SOC_INTEL_FSP_BROADWELL_DE
    select BOARD_ROMSIZE_KB_16384
+	select GENERATE_SMBIOS_TABLES
    select HAVE_ACPI_TABLES
    select HAVE_OPTION_TABLE
    select INTEGRATED_UART
@@ -24,6 +25,8 @@
    select VBOOT if BOARD_FACEBOOK_WATSON_V2
    select VBOOT_MEASURED_BOOT if BOARD_FACEBOOK_WATSON_V2
    select VBOOT_STARTS_IN_ROMSTAGE if BOARD_FACEBOOK_WATSON_V2
+	select VPD
+	select VPD_SMBIOS_VERSION

config MAINBOARD_DIR
    string

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42942 )

Change subject: mb/facebook/watson: select VPD_SMBIOS_VERSION
......................................................................

Patch Set 1: Code-Review+2

[insomniac (Code Review)]

insomniac has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42942 )

Change subject: mb/facebook/watson: select VPD_SMBIOS_VERSION
......................................................................

Patch Set 1: Code-Review+1

LGTM

[Christian Walter (Code Review)]

Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42942 )

Change subject: mb/facebook/watson: select VPD_SMBIOS_VERSION
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42942 )

Change subject: mb/facebook/watson: select VPD_SMBIOS_VERSION
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42942/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/42942/1//COMMIT_MSG@26 
PS1, Line 26: Change-Id: Id559904bfc0afec0668cfaa28303242da4fccf5c
            : 
            : temp
            : 
            : Change-Id: I31fb2cef01161175a0c01094c5445f7fa340f2d0
what's that about, remains of a rebase squash?

[Jonathan Zhang (Code Review)]

Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42942 )

Change subject: mb/facebook/watson: select VPD_SMBIOS_VERSION
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42942/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/42942/1//COMMIT_MSG@26 
PS1, Line 26: Change-Id: Id559904bfc0afec0668cfaa28303242da4fccf5c
            : 
            : temp
            : 
            : Change-Id: I31fb2cef01161175a0c01094c5445f7fa340f2d0
> what's that about, remains of a rebase squash?

Sorry, that was my fault. Corrected.

[Jonathan Zhang (Code Review)]

Hello Philipp Deppenwiese, build bot (Jenkins), Christian Walter, insomniac,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42942

to look at the new patch set (#2).

Change subject: mb/facebook/watson: select VPD_SMBIOS_VERSION
......................................................................

mb/facebook/watson: select VPD_SMBIOS_VERSION

Select VPD, GENERATE_SMBIOS_TABLES, VPD_SMBIOS_VERSION so that
"firmware_version" key value in RO_VPD is reported in smbios type
0 as BIOS version.

TEST=Build coreboot image for WatsonV2, run "vpd -s
firmware_version=FB_OSF_1.2 -i RO_VPD -f build/coreboot.rom"
command to add firmware_version key value pair in RO_VPD,
flash the image to WatsonV2 and reboot it, run dmidecode to verify:

[root@localhost ~]# dmidecode -t 0
...
BIOS Information
    Vendor: coreboot
    Version: FB_OSF_1.2
...

Signed-off-by: Jonathan Zhang 
Change-Id: I31fb2cef01161175a0c01094c5445f7fa340f2d0
---
M src/mainboard/facebook/watson/Kconfig
1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/42942/2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42942 )

Change subject: mb/facebook/watson: select VPD_SMBIOS_VERSION
......................................................................

mb/facebook/watson: select VPD_SMBIOS_VERSION

Select VPD, GENERATE_SMBIOS_TABLES, VPD_SMBIOS_VERSION so that
"firmware_version" key value in RO_VPD is reported in smbios type
0 as BIOS version.

TEST=Build coreboot image for WatsonV2, run "vpd -s
firmware_version=FB_OSF_1.2 -i RO_VPD -f build/coreboot.rom"
command to add firmware_version key value pair in RO_VPD,
flash the image to WatsonV2 and reboot it, run dmidecode to verify:

[root@localhost ~]# dmidecode -t 0
...
BIOS Information
    Vendor: coreboot
    Version: FB_OSF_1.2
...

Signed-off-by: Jonathan Zhang 
Change-Id: I31fb2cef01161175a0c01094c5445f7fa340f2d0
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42942
Tested-by: build bot (Jenkins) 
Reviewed-by: Philipp Deppenwiese 
Reviewed-by: insomniac 
Reviewed-by: Christian Walter 
---
M src/mainboard/facebook/watson/Kconfig
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Philipp Deppenwiese: Looks good to me, approved
  insomniac: Looks good to me, but someone else must approve
  Christian Walter: Looks good to me, approved

diff --git a/src/mainboard/facebook/watson/Kconfig b/src/mainboard/facebook/watson/Kconfig
index f8f93df..2ebc020 100644
--- a/src/mainboard/facebook/watson/Kconfig
+++ b/src/mainboard/facebook/watson/Kconfig
@@ -12,6 +12,7 @@
    def_bool y
    select SOC_INTEL_FSP_BROADWELL_DE
    select BOARD_ROMSIZE_KB_16384
+	select GENERATE_SMBIOS_TABLES
    select HAVE_ACPI_TABLES
    select HAVE_OPTION_TABLE
    select INTEGRATED_UART
@@ -24,6 +25,8 @@
    select VBOOT if BOARD_FACEBOOK_WATSON_V2
    select VBOOT_MEASURED_BOOT if BOARD_FACEBOOK_WATSON_V2
    select VBOOT_STARTS_IN_ROMSTAGE if BOARD_FACEBOOK_WATSON_V2
+	select VPD
+	select VPD_SMBIOS_VERSION

config MAINBOARD_DIR
    string