Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42942 )
Change subject: mb/facebook/watson: select VPD_SMBIOS_VERSION ......................................................................
mb/facebook/watson: select VPD_SMBIOS_VERSION
Select VPD, GENERATE_SMBIOS_TABLES, VPD_SMBIOS_VERSION so that "firmware_version" key value in RO_VPD is reported in smbios type 0 as BIOS version.
TEST=Build coreboot image for WatsonV2, run "vpd -s firmware_version=FB_OSF_1.2 -i RO_VPD -f build/coreboot.rom" command to add firmware_version key value pair in RO_VPD, flash the image to WatsonV2 and reboot it, run dmidecode to verify:
[root@localhost ~]# dmidecode -t 0 ... BIOS Information Vendor: coreboot Version: FB_OSF_1.2 ...
Signed-off-by: Jonathan Zhang jonzhang@fb.com Change-Id: I31fb2cef01161175a0c01094c5445f7fa340f2d0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/42942 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Philipp Deppenwiese zaolin.daisuki@gmail.com Reviewed-by: insomniac insomniac@slackware.it Reviewed-by: Christian Walter christian.walter@9elements.com --- M src/mainboard/facebook/watson/Kconfig 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Philipp Deppenwiese: Looks good to me, approved insomniac: Looks good to me, but someone else must approve Christian Walter: Looks good to me, approved
diff --git a/src/mainboard/facebook/watson/Kconfig b/src/mainboard/facebook/watson/Kconfig index f8f93df..2ebc020 100644 --- a/src/mainboard/facebook/watson/Kconfig +++ b/src/mainboard/facebook/watson/Kconfig @@ -12,6 +12,7 @@ def_bool y select SOC_INTEL_FSP_BROADWELL_DE select BOARD_ROMSIZE_KB_16384 + select GENERATE_SMBIOS_TABLES select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE select INTEGRATED_UART @@ -24,6 +25,8 @@ select VBOOT if BOARD_FACEBOOK_WATSON_V2 select VBOOT_MEASURED_BOOT if BOARD_FACEBOOK_WATSON_V2 select VBOOT_STARTS_IN_ROMSTAGE if BOARD_FACEBOOK_WATSON_V2 + select VPD + select VPD_SMBIOS_VERSION
config MAINBOARD_DIR string