Change in coreboot[master]: cpu/x86/lapic: rename virtual wire mode initialization function

[Felix Held (Code Review)]

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47020 )

Change subject: cpu/x86/lapic: rename virtual wire mode initialization function
......................................................................

cpu/x86/lapic: rename virtual wire mode initialization function

Clarify what the function does by renaming it from do_lapic_init() to
lapic_virtual_wire_mode_init().

Change-Id: Ie4430bf0f6c6bf0081b6aaeace351092bcf7f4ac
Signed-off-by: Felix Held 
---
M src/cpu/x86/lapic/lapic.c
M src/include/cpu/x86/lapic.h
2 files changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/47020/1

diff --git a/src/cpu/x86/lapic/lapic.c b/src/cpu/x86/lapic/lapic.c
index 04ce226..988d664 100644
--- a/src/cpu/x86/lapic/lapic.c
+++ b/src/cpu/x86/lapic/lapic.c
@@ -3,7 +3,7 @@
 #include <cpu/x86/lapic.h>
 #include <console/console.h>

-void do_lapic_init(void)
+void lapic_virtual_wire_mode_init(void)
 {
    /* this is so interrupts work. This is very limited scope --
     * linux will do better later, we hope ...
diff --git a/src/include/cpu/x86/lapic.h b/src/include/cpu/x86/lapic.h
index 5ab5755..f4291ab 100644
--- a/src/include/cpu/x86/lapic.h
+++ b/src/include/cpu/x86/lapic.h
@@ -73,7 +73,7 @@
 # define lapic_read_around(x) lapic_read(x)
 # define lapic_write_around(x, y) lapic_write_atomic((x), (y))

-void do_lapic_init(void);
+void lapic_virtual_wire_mode_init(void);

/* See if I need to initialize the local APIC */
 static inline int need_lapic_init(void)
@@ -84,7 +84,7 @@
 static inline void setup_lapic(void)
 {
    if (need_lapic_init())
-		do_lapic_init();
+		lapic_virtual_wire_mode_init();
    else
    	disable_lapic();
 }

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47020 )

Change subject: cpu/x86/lapic: rename virtual wire mode initialization function
......................................................................

Patch Set 1: Code-Review+2

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47020 )

Change subject: cpu/x86/lapic: rename virtual wire mode initialization function
......................................................................

Patch Set 1: Code-Review+2

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47020 )

Change subject: cpu/x86/lapic: rename virtual wire mode initialization function
......................................................................

Patch Set 1: Code-Review+2

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47020 )

Change subject: cpu/x86/lapic: rename virtual wire mode initialization function
......................................................................

cpu/x86/lapic: rename virtual wire mode initialization function

Clarify what the function does by renaming it from do_lapic_init() to
lapic_virtual_wire_mode_init().

Change-Id: Ie4430bf0f6c6bf0081b6aaeace351092bcf7f4ac
Signed-off-by: Felix Held 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47020
Tested-by: build bot (Jenkins) 
Reviewed-by: Aaron Durbin 
Reviewed-by: Marshall Dawson 
Reviewed-by: Nico Huber 
---
M src/cpu/x86/lapic/lapic.c
M src/include/cpu/x86/lapic.h
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved
  Aaron Durbin: Looks good to me, approved
  Marshall Dawson: Looks good to me, approved

diff --git a/src/cpu/x86/lapic/lapic.c b/src/cpu/x86/lapic/lapic.c
index 04ce226..988d664 100644
--- a/src/cpu/x86/lapic/lapic.c
+++ b/src/cpu/x86/lapic/lapic.c
@@ -3,7 +3,7 @@
 #include <cpu/x86/lapic.h>
 #include <console/console.h>

-void do_lapic_init(void)
+void lapic_virtual_wire_mode_init(void)
 {
    /* this is so interrupts work. This is very limited scope --
     * linux will do better later, we hope ...
diff --git a/src/include/cpu/x86/lapic.h b/src/include/cpu/x86/lapic.h
index 5ab5755..f4291ab 100644
--- a/src/include/cpu/x86/lapic.h
+++ b/src/include/cpu/x86/lapic.h
@@ -73,7 +73,7 @@
 # define lapic_read_around(x) lapic_read(x)
 # define lapic_write_around(x, y) lapic_write_atomic((x), (y))

-void do_lapic_init(void);
+void lapic_virtual_wire_mode_init(void);

/* See if I need to initialize the local APIC */
 static inline int need_lapic_init(void)
@@ -84,7 +84,7 @@
 static inline void setup_lapic(void)
 {
    if (need_lapic_init())
-		do_lapic_init();
+		lapic_virtual_wire_mode_init();
    else
    	disable_lapic();
 }