Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86341?usp=email )
Change subject: soc/mediatek/mt8196: Set the driving strength of SPMI-P to maximum
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86341/comment/09ca8551_8af96633?usp... :
PS3, Line 10: a hardware solution is also required.
a hardware solution of external pull-down is also required.
Done
https://review.coreboot.org/c/coreboot/+/86341/comment/e637a889_ae64aebf?usp... :
PS3, Line 10: maximum
a maximum value of 16mA
Done
File src/soc/mediatek/mt8196/pmif_spmi.c:
https://review.coreboot.org/c/coreboot/+/86341/comment/1dcbd165_f6999779?usp... :
PS3, Line 168: 14
16
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86341?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I131fd04c0313c7ed64bbd123f61d9a6849c8def4
Gerrit-Change-Number: 86341
Gerrit-PatchSet: 4
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Mon, 10 Feb 2025 10:58:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com