Attention is currently required from: Bora Guvendik, Tarun Tuli, Jérémy Compostella, Ravishankar Sarawadi, Kapil Porwal.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68308 )
Change subject: soc/intel/meteorlake: Update pcie snoop/no-snoop latency
......................................................................
Patch Set 6:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68308/comment/4d62cec7_fbb19be0
PS6, Line 7: Update
Increase
https://review.coreboot.org/c/coreboot/+/68308/comment/025e2439_ea59efbb
PS6, Line 10: This fixes an issue where pcie
: was not power gating and blocked S0ix entry.
I prefer to start commit message with a problem description.
https://review.coreboot.org/c/coreboot/+/68308/comment/9ca39e5b_1f2187b3
PS6, Line 12:
Is this a work around? Is this a hardware problem? Are these values documented in some datasheet?
https://review.coreboot.org/c/coreboot/+/68308/comment/0c7666ce_6194d7dd
PS6, Line 13: BUG=none
Why?
File src/soc/intel/meteorlake/pcie.c:
https://review.coreboot.org/c/coreboot/+/68308/comment/93712beb_985c87c1
PS6, Line 9:
Why do you put it here, and not `src/include/device/pciexp.h`?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68308
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9dfb9edbac95d28d50653777466ea172be64f612
Gerrit-Change-Number: 68308
Gerrit-PatchSet: 6
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.corp-partner.google.com
Gerrit-Comment-Date: Tue, 04 Apr 2023 10:39:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment