Attention is currently required from: Arthur Heymans, Marc Jones, Nico Huber, Jonathan Zhang, lichenchen.carl, Nill Ge.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64035 )
Change subject: arch/x86/smbios.c: Allow creating entries for empty DIMM slots
......................................................................
Patch Set 1:
(3 comments)
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/64035/comment/e729bf0d_f618ca04
PS1, Line 281: *current
No need for a pointer, AFAICS.
I just reused the signature of `create_smbios_type17_for_dimm()`. I'll deal with this in a separate commit.
https://review.coreboot.org/c/coreboot/+/64035/comment/3d9cedd5_9f93fc71
PS1, Line 291: t->form_factor = 0x2; /* Unknown */
Shouldn't this be DIMM?
It could be SO-DIMM in some cases.
https://review.coreboot.org/c/coreboot/+/64035/comment/ed7a2adf_55d4a695
PS1, Line 295: t->manufacturer = smbios_add_string(t->eos, "NO DIMM");
: t->serial_number = smbios_add_string(t->eos, "NO DIMM");
: t->asset_tag = smbios_add_string(t->eos, "NO DIMM");
: t->part_number = smbios_add_string(t->eos, "NO DIMM");
Why set these? Isn't that the job of the consuming application, i.e. […]
I borrowed this from CB:63882 but I agree that it's suspicious. I'll check if it's needed or if it can simply be dropped.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64035
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17ae83edf94483bd2eeef5524ff82721c196b8ba
Gerrit-Change-Number: 64035
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nill Ge
geshijian@bytedance.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: lichenchen.carl
lichenchen.carl@bytedance.com
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: lichenchen.carl
lichenchen.carl@bytedance.com
Gerrit-Attention: Nill Ge
geshijian@bytedance.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 04 May 2022 14:09:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment