Attention is currently required from: Arthur Heymans, Marc Jones, Nico Huber, Jonathan Zhang, lichenchen.carl, Nill Ge.

View Change

3 comments:

• File src/arch/x86/smbios.c:

  • Patch Set #1, Line 281: *current

    No need for a pointer, AFAICS.

    I just reused the signature of `create_smbios_type17_for_dimm()`. I'll deal with this in a separate commit.

  • Patch Set #1, Line 291: t->form_factor = 0x2; /* Unknown */

    Shouldn't this be DIMM?

    It could be SO-DIMM in some cases.

  • Patch Set #1, Line 295:

    	t->manufacturer = smbios_add_string(t->eos, "NO DIMM");
    	t->serial_number = smbios_add_string(t->eos, "NO DIMM");
    	t->asset_tag = smbios_add_string(t->eos, "NO DIMM");
    	t->part_number = smbios_add_string(t->eos, "NO DIMM");
    

    Why set these? Isn't that the job of the consuming application, i.e. […]

    I borrowed this from CB:63882 but I agree that it's suspicious. I'll check if it's needed or if it can simply be dropped.

To view, visit change 64035. To unsubscribe, or for help writing mail filters, visit settings.