[XL] Change in coreboot[main]: mainboard/hardkernel: Add ODROID H4+ initial support - coreboot-gerrit

11 Sep 2024


      Attention is currently required from: Alicja Michalska, David Milosevic, Felix Held, Michał Żygowski.
Matt DeVillier has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/84213?usp=email )
Change subject: mainboard/hardkernel: Add ODROID H4+ initial support
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/hardkernel/odroid_h4/gpio.c:
https://review.coreboot.org/c/coreboot/+/84213/comment/eb318bed_e59be967?usp... :
PS2, Line 8: #define PAD_CFG_GPIO_BIDIRECT(pad, val, pull, rst, trig, own)		\
...
shouldn't this go into one of the soc's gpio header files?
can be removed if rebased on top of CB:42914
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84213?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iee066cb0da27e3bf7ce52fc199396185912893aa
Gerrit-Change-Number: 84213
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Alicja Michalska ahplka19@gmail.com
Gerrit-Reviewer: David Milosevic David.Milosevic@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Matt DeVillier matt.devillier@gmail.com
Gerrit-Attention: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Attention: Alicja Michalska ahplka19@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Attention: David Milosevic David.Milosevic@9elements.com
Gerrit-Comment-Date: Wed, 11 Sep 2024 17:51:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de