Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35454 )
Change subject: nb/intel/nehalem: Enabled VBOOT support ......................................................................
nb/intel/nehalem: Enabled VBOOT support
Tested on Lenovo T410.
Change-Id: I86100be79bf2337d65b688edba34b87f3ac18cb6 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/northbridge/intel/nehalem/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/35454/1
diff --git a/src/northbridge/intel/nehalem/Kconfig b/src/northbridge/intel/nehalem/Kconfig index 9c74ef6..7b87588 100644 --- a/src/northbridge/intel/nehalem/Kconfig +++ b/src/northbridge/intel/nehalem/Kconfig @@ -24,6 +24,10 @@
if NORTHBRIDGE_INTEL_NEHALEM
+config VBOOT + select VBOOT_MUST_REQUEST_DISPLAY + select VBOOT_STARTS_IN_ROMSTAGE + config MMCONF_BUS_NUMBER int default 256
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35454 )
Change subject: nb/intel/nehalem: Enabled VBOOT support ......................................................................
Patch Set 1:
Julius, can you tell me if there are some plans wrt. VBOOT_STARTS_IN_ROMSTAGE once C_ENVIRONMENT_BOOTBLOCK becomes compulsory with next release?
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35454 )
Change subject: nb/intel/nehalem: Enabled VBOOT support ......................................................................
Patch Set 1:
Patch Set 1:
Julius, can you tell me if there are some plans wrt. VBOOT_STARTS_IN_ROMSTAGE once C_ENVIRONMENT_BOOTBLOCK becomes compulsory with next release?
OT but on for instance on braswell VBOOT_START_IN_ROMSTAGE is necessary even though it has C_ENVIRONMENT_BOOTBLOCK since it's CAR region is to small to hold the 12K VBOOT2_WORK. (FSP-T is necessary on FSP1.0 and FSP1.1 so no possible fix on our side)
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35454 )
Change subject: nb/intel/nehalem: Enabled VBOOT support ......................................................................
Patch Set 1:
I don't think we have any specific plans for VBOOT_STARTS_IN_ROMSTAGE. We're never planning to use it on any new platforms so we're not going to put any effort into it, but happy to leave it alive as long as it's useful for someone.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35454 )
Change subject: nb/intel/nehalem: Enabled VBOOT support ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35454 )
Change subject: nb/intel/nehalem: Enabled VBOOT support ......................................................................
nb/intel/nehalem: Enabled VBOOT support
Tested on Lenovo T410.
Change-Id: I86100be79bf2337d65b688edba34b87f3ac18cb6 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35454 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/northbridge/intel/nehalem/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved
diff --git a/src/northbridge/intel/nehalem/Kconfig b/src/northbridge/intel/nehalem/Kconfig index f500d63..3adf698 100644 --- a/src/northbridge/intel/nehalem/Kconfig +++ b/src/northbridge/intel/nehalem/Kconfig @@ -24,6 +24,10 @@
if NORTHBRIDGE_INTEL_NEHALEM
+config VBOOT + select VBOOT_MUST_REQUEST_DISPLAY + select VBOOT_STARTS_IN_ROMSTAGE + config MMCONF_BUS_NUMBER int default 256