Change in coreboot[master]: nb/intel/i945: Fix C1DRBs values when channel B is empty - coreboot-gerrit

22 Jun 2018


      Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/27204 )
Change subject: nb/intel/i945: Fix C1DRBs values when channel B is empty
......................................................................
Patch Set 5:
indeed, the code is correct.
however, the old commented (dead) code is not correct:
#if 0
    /* Exception: Channel 1 is not populated. C1DRB stays zero */
    if (sysinfo->dimm[2] == SYSINFO_DIMM_NOT_POPULATED &&
    		sysinfo->dimm[3] == SYSINFO_DIMM_NOT_POPULATED)
    	cum1 = 0;
#endif
-- 
To view, visit https://review.coreboot.org/27204
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic26103aac7f920e5696b445e125d33405df4f43b
Gerrit-Change-Number: 27204
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes HAOUAS ehaouas@noos.fr
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Elyes HAOUAS ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 22 Jun 2018 12:18:46 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No