[XS] Change in coreboot[main]: mb/google/rauru: Determine PCIe init by storage type - coreboot-gerrit

7 Jan 2025


      Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85828?usp=email )
Change subject: mb/google/rauru: Determine PCIe init by storage type
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/rauru/mainboard.c:
https://review.coreboot.org/c/coreboot/+/85828/comment/9f44ad14_bbb89339?usp... :
PS3, Line 72: _BASE_TYPE_NVME
...
Variables starting with `_` are private to that file. Use `STORAGE_NVME` here. […]
Changed to `STORAGE_NVME`. Prefer other approaches when we have a complex storage combination.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/85828?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaee7c346f4eaf004437aed3554d9275c9b821ad8
Gerrit-Change-Number: 85828
Gerrit-PatchSet: 4
Gerrit-Owner: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Jarried Lin jarried.lin@mediatek.com
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Tue, 07 Jan 2025 10:02:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com