[XS] Change in coreboot[main]: mb/google/rex: Enable Sign-of-Life support - coreboot-gerrit

1 Nov 2023


      Attention is currently required from: Eran Mitrani, Kapil Porwal, Martin L Roth, Shelley Chen, Subrata Banik, Tarun.
Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78246?usp=email )
Change subject: mb/google/rex: Enable Sign-of-Life support
......................................................................
Patch Set 14:
(1 comment)
File src/mainboard/google/rex/Kconfig:
https://review.coreboot.org/c/coreboot/+/78246/comment/6638cdfc_337131dd :
PS12, Line 32: 	select SOC_INTEL_METEORLAKE_SIGN_OF_LIFE
...
Could this be move down to line 157 or so? Inside the `config CHROMEOS` block. […]
It seems like a fair request to me. Done.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/78246?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7ebacddded6995862ec16e17cc31dce82cbc8cf9
Gerrit-Change-Number: 78246
Gerrit-PatchSet: 14
Gerrit-Owner: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: Eran Mitrani mitrani@google.com
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tarun tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Shelley Chen shchen@google.com
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Eran Mitrani mitrani@google.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Kapil Porwal kapilporwal@google.com
Gerrit-Attention: Tarun tstuli@gmail.com
Gerrit-Comment-Date: Wed, 01 Nov 2023 19:40:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth gaumless@gmail.com
Gerrit-MessageType: comment