Attention is currently required from: Martin Roth.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52198 )
Change subject: soc/amd/cezanne: add SMU settings to devicetree
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/cezanne/fsp_m_params.c:
https://review.coreboot.org/c/coreboot/+/52198/comment/c1b19615_a3a17c49
PS2, Line 95: mcfg->stapm_boost = config->stapm_boost;
: mcfg->stapm_time_constant = config->stapm_time_constant;
: mcfg->apu_only_sppt_limit = config->apu_only_sppt_limit;
: mcfg->sustained_power_limit = config->sustained_power_limit;
: mcfg->fast_ppt_limit = config->fast_ppt_limit;
: mcfg->slow_ppt_limit = config->slow_ppt_limit;
Is it valid to have a stapm_time_constant of 0 when all of the other values are set? […]
thanks for verifying with the docs
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52198
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifbcc85cc10d59f1418bbf0ed4a0dc7549d589a26
Gerrit-Change-Number: 52198
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Comment-Date: Wed, 21 Apr 2021 22:13:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment