Attention is currently required from: Marc Jones, Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Paul Menzel, Stefan Reinauer, ron minnich, Tim Chu.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51824 )
Change subject: Documentation/mb/ocp: Update Delta Lake documentation
......................................................................
Patch Set 5: Code-Review+1
(4 comments)
File Documentation/mainboard/ocp/deltalake.md:
https://review.coreboot.org/c/coreboot/+/51824/comment/ba85f813_2f3e7319
PS5, Line 31: Intel.
Align below ACM as done above.
Or even move it to the previous line (it should fit)
https://review.coreboot.org/c/coreboot/+/51824/comment/6b7672eb_57606215
PS5, Line 103: - KM/BPM signing
Don’t use tabs for consistency?
Yeah, I'd use 8 spaces
https://review.coreboot.org/c/coreboot/+/51824/comment/28097e98_b1082896
PS5, Line 151: CLTT
CLTT = Closed Loop Thermal Throttling? I'd add the full form in parentheses:
- CLTT (Closed Loop Thermal Throttling)
https://review.coreboot.org/c/coreboot/+/51824/comment/c1e68483_29b44a9d
PS5, Line 152: - ProcHot
I have no idea, what that means.
PROCHOT# is a signal that is used to report "Processor Hot", and activate thermal protections. I forget about the specifics. I agree it would be nice to elaborate a bit on what exactly doesn't work
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51824
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd6ab251cd7806cf8cd3f984ad88c091f85035cf
Gerrit-Change-Number: 51824
Gerrit-PatchSet: 5
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Fri, 02 Apr 2021 08:05:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment