Attention is currently required from: David Wu, Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Alan Huang. Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56539 )
Change subject: mb/google/brya: Enable DDR4 SODIMM for brask ......................................................................
Patch Set 12:
(6 comments)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/56539/comment/3ed8ebb8_0c022b1d PS3, Line 9: select SPD_CACHE_IN_FMAP
Is load_spd_cache necessary? Refer to the below file, I didn't see they call the function. […]
As Furquan mentioned in the previous comment, we need to move it to the common driver. So, it is unnecessary to add it in this CL. I'll create a bug to track it.
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/56539/comment/000ce273_dcb22678 PS12, Line 72: src/mainboard/google/brya/ src/mainboard/$(CONFIG_MAINBOARD_DIR)/
https://review.coreboot.org/c/coreboot/+/56539/comment/0e39e4ff_6bcfa3b8 PS12, Line 73: src/mainboard/google/brya/ src/mainboard/$(CONFIG_MAINBOARD_DIR)/
File src/mainboard/google/brya/variants/baseboard/brask/memory.c:
https://review.coreboot.org/c/coreboot/+/56539/comment/450a4d92_a056a183 PS12, Line 7: baseboard_memcfg Please also refer to https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thir... for the setting. It would be good to clarify the setting in b:194055762
https://review.coreboot.org/c/coreboot/+/56539/comment/696648e8_18495b7e PS12, Line 15: .targets = {40, 30, 30, 30, 30}, May i know where you get this value from? Please clarify it in b:194055762
https://review.coreboot.org/c/coreboot/+/56539/comment/cd25a46a_9befbe2e PS12, Line 38: spd_info->smbus[0].addr_dimm[0] = 0xA0; : spd_info->smbus[0].addr_dimm[1] = 0xA1; : spd_info->smbus[1].addr_dimm[0] = 0xA4; : spd_info->smbus[1].addr_dimm[1] = 0xA5; Could you please double check the address value here? It changes from 0x50,0x51,0x52,0x53 to 0xA0,0xA1,0xA4,0xA5. Please clarify it in b:194055762
-
Zhuohao Lee (Code Review)