Patrick Rudolph has uploaded a new change for review. ( https://review.coreboot.org/19955 )
Change subject: mb/lenovo/*/cmos: Remove unused option and checksum fix ......................................................................
mb/lenovo/*/cmos: Remove unused option and checksum fix
Fix for all Sandy-Bridge and Ivy-Bridge devices.
Remove unused option "hyper_threading". Increase CMOS checksum range to cover all user adjustable settings.
Change-Id: I02f7af13d9c82d7f531d4b49b3bc0e5a20c14b55 Signed-off-by: Patrick Rudolph siro@das-labor.org --- M src/mainboard/lenovo/l520/cmos.default M src/mainboard/lenovo/l520/cmos.layout M src/mainboard/lenovo/t420/cmos.default M src/mainboard/lenovo/t420/cmos.layout M src/mainboard/lenovo/t420s/cmos.default M src/mainboard/lenovo/t420s/cmos.layout M src/mainboard/lenovo/t430s/cmos.default M src/mainboard/lenovo/t430s/cmos.layout M src/mainboard/lenovo/t520/cmos.default M src/mainboard/lenovo/t520/cmos.layout M src/mainboard/lenovo/t530/cmos.default M src/mainboard/lenovo/t530/cmos.layout M src/mainboard/lenovo/x1_carbon_gen1/cmos.default M src/mainboard/lenovo/x1_carbon_gen1/cmos.layout M src/mainboard/lenovo/x220/cmos.default M src/mainboard/lenovo/x220/cmos.layout M src/mainboard/lenovo/x230/cmos.default M src/mainboard/lenovo/x230/cmos.layout 18 files changed, 18 insertions(+), 36 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/19955/1
diff --git a/src/mainboard/lenovo/l520/cmos.default b/src/mainboard/lenovo/l520/cmos.default index 526a6d6..92dc2e1 100644 --- a/src/mainboard/lenovo/l520/cmos.default +++ b/src/mainboard/lenovo/l520/cmos.default @@ -13,6 +13,5 @@ fn_ctrl_swap=Disable sticky_fn=Disable trackpoint=Enable -hyper_threading=Enable backlight=Both hybrid_graphics_mode=Integrated Only diff --git a/src/mainboard/lenovo/l520/cmos.layout b/src/mainboard/lenovo/l520/cmos.layout index a151b7e..3c450c7 100644 --- a/src/mainboard/lenovo/l520/cmos.layout +++ b/src/mainboard/lenovo/l520/cmos.layout @@ -72,8 +72,7 @@ 422 2 e 10 backlight
# coreboot config options: cpu -424 1 e 2 hyper_threading -#425 7 r 0 unused +#424 8 r 0 unused
# coreboot config options: northbridge 432 3 e 11 gfx_uma_size @@ -140,4 +139,4 @@ # ----------------------------------------------------------------- checksums
-checksum 392 415 984 +checksum 392 447 984 diff --git a/src/mainboard/lenovo/t420/cmos.default b/src/mainboard/lenovo/t420/cmos.default index cfb7552..0fc3e55 100644 --- a/src/mainboard/lenovo/t420/cmos.default +++ b/src/mainboard/lenovo/t420/cmos.default @@ -13,5 +13,4 @@ fn_ctrl_swap=Disable sticky_fn=Disable trackpoint=Enable -hyper_threading=Enable hybrid_graphics_mode=Integrated Only diff --git a/src/mainboard/lenovo/t420/cmos.layout b/src/mainboard/lenovo/t420/cmos.layout index 79a3a68..924b0f1 100644 --- a/src/mainboard/lenovo/t420/cmos.layout +++ b/src/mainboard/lenovo/t420/cmos.layout @@ -72,8 +72,7 @@ #422 2 r 1 unused
# coreboot config options: cpu -424 1 e 2 hyper_threading -#425 7 r 0 unused +#424 8 r 0 unused
# coreboot config options: northbridge 432 3 e 11 gfx_uma_size @@ -142,4 +141,4 @@ # ----------------------------------------------------------------- checksums
-checksum 392 415 984 +checksum 392 447 984 diff --git a/src/mainboard/lenovo/t420s/cmos.default b/src/mainboard/lenovo/t420s/cmos.default index cfb7552..0fc3e55 100644 --- a/src/mainboard/lenovo/t420s/cmos.default +++ b/src/mainboard/lenovo/t420s/cmos.default @@ -13,5 +13,4 @@ fn_ctrl_swap=Disable sticky_fn=Disable trackpoint=Enable -hyper_threading=Enable hybrid_graphics_mode=Integrated Only diff --git a/src/mainboard/lenovo/t420s/cmos.layout b/src/mainboard/lenovo/t420s/cmos.layout index ec9be11..e9e582d 100644 --- a/src/mainboard/lenovo/t420s/cmos.layout +++ b/src/mainboard/lenovo/t420s/cmos.layout @@ -72,8 +72,7 @@ #422 2 r 1 unused
# coreboot config options: cpu -424 1 e 2 hyper_threading -#425 7 r 0 unused +#424 8 r 0 unused
# coreboot config options: northbridge 432 3 e 11 gfx_uma_size @@ -142,4 +141,4 @@ # ----------------------------------------------------------------- checksums
-checksum 392 415 984 +checksum 392 447 984 diff --git a/src/mainboard/lenovo/t430s/cmos.default b/src/mainboard/lenovo/t430s/cmos.default index 00e8863..f7e38d2 100644 --- a/src/mainboard/lenovo/t430s/cmos.default +++ b/src/mainboard/lenovo/t430s/cmos.default @@ -13,5 +13,4 @@ fn_ctrl_swap=Disable sticky_fn=Disable trackpoint=Enable -hyper_threading=Enable backlight=Both diff --git a/src/mainboard/lenovo/t430s/cmos.layout b/src/mainboard/lenovo/t430s/cmos.layout index 73bbe3a..f116bab 100644 --- a/src/mainboard/lenovo/t430s/cmos.layout +++ b/src/mainboard/lenovo/t430s/cmos.layout @@ -72,8 +72,7 @@ 422 2 e 10 backlight
# coreboot config options: cpu -424 1 e 2 hyper_threading -#425 7 r 0 unused +#424 8 r 0 unused
# coreboot config options: northbridge 432 3 e 11 gfx_uma_size @@ -138,4 +137,4 @@ # ----------------------------------------------------------------- checksums
-checksum 392 415 984 +checksum 392 447 984 diff --git a/src/mainboard/lenovo/t520/cmos.default b/src/mainboard/lenovo/t520/cmos.default index 526a6d6..92dc2e1 100644 --- a/src/mainboard/lenovo/t520/cmos.default +++ b/src/mainboard/lenovo/t520/cmos.default @@ -13,6 +13,5 @@ fn_ctrl_swap=Disable sticky_fn=Disable trackpoint=Enable -hyper_threading=Enable backlight=Both hybrid_graphics_mode=Integrated Only diff --git a/src/mainboard/lenovo/t520/cmos.layout b/src/mainboard/lenovo/t520/cmos.layout index a151b7e..3c450c7 100644 --- a/src/mainboard/lenovo/t520/cmos.layout +++ b/src/mainboard/lenovo/t520/cmos.layout @@ -72,8 +72,7 @@ 422 2 e 10 backlight
# coreboot config options: cpu -424 1 e 2 hyper_threading -#425 7 r 0 unused +#424 8 r 0 unused
# coreboot config options: northbridge 432 3 e 11 gfx_uma_size @@ -140,4 +139,4 @@ # ----------------------------------------------------------------- checksums
-checksum 392 415 984 +checksum 392 447 984 diff --git a/src/mainboard/lenovo/t530/cmos.default b/src/mainboard/lenovo/t530/cmos.default index 526a6d6..92dc2e1 100644 --- a/src/mainboard/lenovo/t530/cmos.default +++ b/src/mainboard/lenovo/t530/cmos.default @@ -13,6 +13,5 @@ fn_ctrl_swap=Disable sticky_fn=Disable trackpoint=Enable -hyper_threading=Enable backlight=Both hybrid_graphics_mode=Integrated Only diff --git a/src/mainboard/lenovo/t530/cmos.layout b/src/mainboard/lenovo/t530/cmos.layout index d6d671c..cdcc896 100644 --- a/src/mainboard/lenovo/t530/cmos.layout +++ b/src/mainboard/lenovo/t530/cmos.layout @@ -72,8 +72,7 @@ 422 2 e 10 backlight
# coreboot config options: cpu -424 1 e 2 hyper_threading -#425 7 r 0 unused +#424 8 r 0 unused
# coreboot config options: northbridge 432 3 e 11 gfx_uma_size @@ -142,4 +141,4 @@ # ----------------------------------------------------------------- checksums
-checksum 392 415 984 +checksum 392 447 984 diff --git a/src/mainboard/lenovo/x1_carbon_gen1/cmos.default b/src/mainboard/lenovo/x1_carbon_gen1/cmos.default index 00e8863..f7e38d2 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/cmos.default +++ b/src/mainboard/lenovo/x1_carbon_gen1/cmos.default @@ -13,5 +13,4 @@ fn_ctrl_swap=Disable sticky_fn=Disable trackpoint=Enable -hyper_threading=Enable backlight=Both diff --git a/src/mainboard/lenovo/x1_carbon_gen1/cmos.layout b/src/mainboard/lenovo/x1_carbon_gen1/cmos.layout index 14602ff..3766453 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/cmos.layout +++ b/src/mainboard/lenovo/x1_carbon_gen1/cmos.layout @@ -72,8 +72,7 @@ 422 2 e 10 backlight
# coreboot config options: cpu -424 1 e 2 hyper_threading -#425 7 r 0 unused +#424 8 r 0 unused
# coreboot config options: northbridge 432 3 e 11 gfx_uma_size @@ -139,4 +138,4 @@ # ----------------------------------------------------------------- checksums
-checksum 392 415 984 +checksum 392 447 984 diff --git a/src/mainboard/lenovo/x220/cmos.default b/src/mainboard/lenovo/x220/cmos.default index 91331ab..5424552 100644 --- a/src/mainboard/lenovo/x220/cmos.default +++ b/src/mainboard/lenovo/x220/cmos.default @@ -14,4 +14,3 @@ fn_ctrl_swap=Disable sticky_fn=Disable trackpoint=Enable -hyper_threading=Enable diff --git a/src/mainboard/lenovo/x220/cmos.layout b/src/mainboard/lenovo/x220/cmos.layout index 0f57058..77979b3 100644 --- a/src/mainboard/lenovo/x220/cmos.layout +++ b/src/mainboard/lenovo/x220/cmos.layout @@ -73,8 +73,7 @@ #423 1 r 1 unused
# coreboot config options: cpu -424 1 e 2 hyper_threading -#425 7 r 0 unused +#424 8 r 0 unused
# coreboot config options: northbridge 432 3 e 11 gfx_uma_size @@ -141,4 +140,4 @@ # ----------------------------------------------------------------- checksums
-checksum 392 415 984 +checksum 392 447 984 diff --git a/src/mainboard/lenovo/x230/cmos.default b/src/mainboard/lenovo/x230/cmos.default index 00e8863..f7e38d2 100644 --- a/src/mainboard/lenovo/x230/cmos.default +++ b/src/mainboard/lenovo/x230/cmos.default @@ -13,5 +13,4 @@ fn_ctrl_swap=Disable sticky_fn=Disable trackpoint=Enable -hyper_threading=Enable backlight=Both diff --git a/src/mainboard/lenovo/x230/cmos.layout b/src/mainboard/lenovo/x230/cmos.layout index 14602ff..3766453 100644 --- a/src/mainboard/lenovo/x230/cmos.layout +++ b/src/mainboard/lenovo/x230/cmos.layout @@ -72,8 +72,7 @@ 422 2 e 10 backlight
# coreboot config options: cpu -424 1 e 2 hyper_threading -#425 7 r 0 unused +#424 8 r 0 unused
# coreboot config options: northbridge 432 3 e 11 gfx_uma_size @@ -139,4 +138,4 @@ # ----------------------------------------------------------------- checksums
-checksum 392 415 984 +checksum 392 447 984
-
Patrick Rudolph (Code Review)