[S] Change in coreboot[master]: acpi/acpi.c: Fix einj generation pointer arithmetics

[Jonathan Zhang (Code Review)]

Attention is currently required from: Lance Zhao, Arthur Heymans, Tim Wawrzynczak, Angel Pons, Shuming Chu (Shuming), Elyes Haouas.

Hello Lance Zhao, Arthur Heymans, build bot (Jenkins), Tim Wawrzynczak, Angel Pons, Shuming Chu (Shuming),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/69326

to look at the new patch set (#2).

Change subject: acpi/acpi.c: Fix einj generation pointer arithmetics
......................................................................

acpi/acpi.c: Fix einj generation pointer arithmetics

Without a cast the aritmetics of

tat = einj + sizeof(acpi_einj_smi_t)

is the same as

tat = (uintptr_t)einj + size(acpi_einj_smi_t) * size(acpi_einj_smi_t)

So it overshoots the intended offset by a lot.

This issue only came apparent because now einj is in the small IMD
region which is close to TSEG. With the wrong aritmetics the tat
pointer ended up inside TSEG which is not accessible from the OS
causing exceptions.

TEST: observe that tat pointer is inside the small IMD below
TSEG (0x78000000 on our setup).
"acpi_create_einj trigger_action_table = 0x77ffe89c"

Change-Id: I3ab64b95c33eef01b2048816a21e17855bcb2f54
Signed-off-by: Arthur Heymans 
Signed-off-by: Jonathan Zhang 
---
M src/acpi/acpi.c
1 file changed, 31 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/69326/2