Change in coreboot[master]: soc/intel/alderlake: Make use of is_devfn_enabled() function

[Subrata Banik (Code Review)]

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Angel Pons, Andrey Petrov, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55292 )

Change subject: soc/intel/alderlake: Make use of is_devfn_enabled() function
......................................................................

Patch Set 5:

(6 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/55292/comment/c13c539a_68a2d787 
PS4, Line 15: built
> nit: build

Ack

File src/soc/intel/alderlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/55292/comment/69dee786_8a8715e5 
PS4, Line 186: 			dev->enabled = 0;
> This also disabled the device in the devicetree

Ack

https://review.coreboot.org/c/coreboot/+/55292/comment/0fe0aac8_c42ff1bb 
PS4, Line 247:
> nit: Drop blank line?

Ack

File src/soc/intel/alderlake/romstage/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/55292/comment/17263415_85dc5937 
PS4, Line 72: if (!CONFIG(SOC_INTEL_DISABLE_IGD) && is_devfn_enabled(SA_DEVFN_IGD))
            : 		m_cfg->InternalGfx = 1;
            : 	else
            : 		m_cfg->InternalGfx = 0;
> Should fit in one line: […]

Ack

https://review.coreboot.org/c/coreboot/+/55292/comment/71fdb4c1_3f8fdede 
PS4, Line 183:
> nit: Drop blank line?

Ack

https://review.coreboot.org/c/coreboot/+/55292/comment/31830e99_35b5fb5e 
PS4, Line 186: 
             : 	m_cfg->TcssItbtPcie0En = is_devfn_enabled(SA_DEVFN_TBT0);
             : 
             : 	m_cfg->TcssItbtPcie1En = is_devfn_enabled(SA_DEVFN_TBT1);
             : 
             : 	m_cfg->TcssItbtPcie2En = is_devfn_enabled(SA_DEVFN_TBT2);
             : 
             : 	m_cfg->TcssItbtPcie3En = is_devfn_enabled(SA_DEVFN_TBT3);
> nit: Drop blank lines in between?

Ack