Attention is currently required from: Marc Jones, Jonathan Zhang, Angel Pons, Patrick Rudolph, Tim Chu.
Rocky Phagura has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50843 )
Change subject: src/soc/intel/xeon_sp/cpx: Add enable IIO error masks
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/xeon_sp/cpx/Kconfig:
https://review.coreboot.org/c/coreboot/+/50843/comment/e2e1a8ba_eee5cd0c
PS3, Line 16: default 4
This doesn't need to be a config. […]
I thought the PCIE bifurcation could affect this but I think it should be okay. The bifurcation is only for the root ports and doesn't really affect the dynamic number of devices. Therefore, I've removed the Kconfig option and instead made a #define in pci_devs.h
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50843
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I99f05928930bbf1f617c2d8ce31e8df2a6fd15e6
Gerrit-Change-Number: 50843
Gerrit-PatchSet: 3
Gerrit-Owner: Rocky Phagura
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rocky Phagura
rphagura@fb.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Fri, 19 Feb 2021 16:29:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marc Jones
marc@marcjonesconsulting.com
Gerrit-MessageType: comment