Attention is currently required from: Patrick Georgi, Paul Menzel, Nicholas Chin.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73816 )
Change subject: Documentation/tutorial: Improve clarity of Part 1
......................................................................
Patch Set 3: Code-Review+1
(5 comments)
Patchset:
PS3:
Looks good 😊
File Documentation/tutorial/part1.md:
https://review.coreboot.org/c/coreboot/+/73816/comment/5ee733e3_994182db
PS3, Line 249: Normally
nit: Usually
Sounds better in my opinion. Feel free to mark as resolved.
https://review.coreboot.org/c/coreboot/+/73816/comment/55473873_754613ec
PS3, Line 255: load
I would remove that
https://review.coreboot.org/c/coreboot/+/73816/comment/417fa798_6f86c599
PS3, Line 256: payload
payloads
https://review.coreboot.org/c/coreboot/+/73816/comment/e150e11a_5621045a
PS3, Line 259: explicity
explicitly
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73816
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13206aa05a425ddfe33ee35feff0db490585a59f
Gerrit-Change-Number: 73816
Gerrit-PatchSet: 3
Gerrit-Owner: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Georgi
patrick@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Wed, 10 May 2023 22:08:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment