Attention is currently required from: Julius Werner, Angel Pons, Patrick Rudolph. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59008 )
Change subject: mb/google,samsung: Drop init_bootmode_straps() ......................................................................
Patch Set 3:
(2 comments)
File src/include/bootmode.h:
https://review.coreboot.org/c/coreboot/+/59008/comment/65fd28c9_5b7d1ad1 PS2, Line 19: void stash_bootmode(int flag_spi_wp, int flag_rec_mode);
This is an old ugly hack on ancient devices that I'd prefer not to propagate to a top level API if p […]
At least for samsung/lumpy, rec mode switch is momentary push button. The state was filled late in ramstage in fill_lb_gpios().
File src/mainboard/google/beltino/chromeos.c:
https://review.coreboot.org/c/coreboot/+/59008/comment/468ceffb_8fb9a0cc PS3, Line 16: !get_recovery_mode_switch(), "presence"}, Does the initial state sampled late in ramstage have any significance? We're adding an actual GPIO pin and polarity here.
-
Kyösti Mälkki (Code Review)