Hello Manoj Gupta,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/35316
to review the following change.
Change subject: futility: Use HOSTPKGCONFIG for host PKG_CONFIG ......................................................................
futility: Use HOSTPKGCONFIG for host PKG_CONFIG
futility is built for the host. However, when cross-compiling, the target's pkg-config is called to get the library paths which can add paths from the cross-compilation tree instead of host. e.g. /build/elm/usr/bin/pkg-config gets called instead of /usr/bin/pkg-config . /build/elm/usr/bin/pkg-config adds the paths specific to the cross-compilation target e.g. /build/elm/usr/lib instead of /usr/lib.
This causes linker to complain that files in library paths do not match the architecture. BFD produces a warning while LLD errors out.
Fix this by passing PKG_CONFIG from host when building futility.
BUG=chromium:999217 TEST=coreboot builds BRANCH=None
Cq-Depend: chromium:1778519 Change-Id: Id3afbf25001cf3daa72f36a290c93136cf9f162d Signed-off-by: Patrick Georgi pgeorgi@google.com --- M util/futility/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/35316/1
diff --git a/util/futility/Makefile.inc b/util/futility/Makefile.inc index 782953e..87764a7 100644 --- a/util/futility/Makefile.inc +++ b/util/futility/Makefile.inc @@ -5,6 +5,7 @@ unset CFLAGS LDFLAGS; $(MAKE) -C $(VBOOT_SOURCE) \ BUILD=$(abspath $@/../..) \ CC="$(HOSTCC)" \ + PKG_CONFIG="$(HOSTPKGCONFIG)" \ V=$(V) \ $(abspath $@)
Hello build bot (Jenkins), Manoj Gupta, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35316
to look at the new patch set (#2).
Change subject: futility: Use HOSTPKGCONFIG for host PKG_CONFIG ......................................................................
futility: Use HOSTPKGCONFIG for host PKG_CONFIG
futility is built for the host. However, when cross-compiling, the target's pkg-config is called to get the library paths which can add paths from the cross-compilation tree instead of host. e.g. /build/elm/usr/bin/pkg-config gets called instead of /usr/bin/pkg-config . /build/elm/usr/bin/pkg-config adds the paths specific to the cross-compilation target e.g. /build/elm/usr/lib instead of /usr/lib.
This causes linker to complain that files in library paths do not match the architecture. BFD produces a warning while LLD errors out.
Fix this by passing PKG_CONFIG from host when building futility.
BUG=chromium:999217 TEST=coreboot builds BRANCH=None
Cq-Depend: chromium:1778519 Change-Id: Id3afbf25001cf3daa72f36a290c93136cf9f162d Signed-off-by: Patrick Georgi pgeorgi@google.com --- M util/futility/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/35316/2
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35316 )
Change subject: futility: Use HOSTPKGCONFIG for host PKG_CONFIG ......................................................................
Patch Set 2: Code-Review+2
Manoj Gupta has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35316 )
Change subject: futility: Use HOSTPKGCONFIG for host PKG_CONFIG ......................................................................
Patch Set 2:
Thanks Patrick!
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35316 )
Change subject: futility: Use HOSTPKGCONFIG for host PKG_CONFIG ......................................................................
futility: Use HOSTPKGCONFIG for host PKG_CONFIG
futility is built for the host. However, when cross-compiling, the target's pkg-config is called to get the library paths which can add paths from the cross-compilation tree instead of host. e.g. /build/elm/usr/bin/pkg-config gets called instead of /usr/bin/pkg-config . /build/elm/usr/bin/pkg-config adds the paths specific to the cross-compilation target e.g. /build/elm/usr/lib instead of /usr/lib.
This causes linker to complain that files in library paths do not match the architecture. BFD produces a warning while LLD errors out.
Fix this by passing PKG_CONFIG from host when building futility.
BUG=chromium:999217 TEST=coreboot builds BRANCH=None
Cq-Depend: chromium:1778519 Change-Id: Id3afbf25001cf3daa72f36a290c93136cf9f162d Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35316 Reviewed-by: Julius Werner jwerner@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/futility/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved
diff --git a/util/futility/Makefile.inc b/util/futility/Makefile.inc index 782953e..06e724c 100644 --- a/util/futility/Makefile.inc +++ b/util/futility/Makefile.inc @@ -5,6 +5,7 @@ unset CFLAGS LDFLAGS; $(MAKE) -C $(VBOOT_SOURCE) \ BUILD=$(abspath $@/../..) \ CC="$(HOSTCC)" \ + $(if $(HOSTPKGCONFIG), PKG_CONFIG="$(HOSTPKGCONFIG)") \ V=$(V) \ $(abspath $@)
-
Julius Werner (Code Review) -
Manoj Gupta (Code Review)
-
Patrick Georgi (Code Review)