Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42688 )
Change subject: soc/amd/common: Use gpio_setbits32()
......................................................................
Patch Set 6:
(1 comment)
Think we can merge this as is.
https://review.coreboot.org/c/coreboot/+/42688/6/src/soc/amd/common/block/gp...
File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/42688/6/src/soc/amd/common/block/gp...
PS6, Line 221: __gpio_setbits32
Whatever works for you. That mem_read_write32() was just too obscure to my eyes.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42688
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4413d113dff550900348a44f71b949b7547a9cfc
Gerrit-Change-Number: 42688
Gerrit-PatchSet: 6
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 29 Jun 2020 17:23:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment