Attention is currently required from: Caveh Jalali, Jayvik Desai, Paul Menzel, Subrata Banik.
Boris Mittelberg has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/85326?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: ec/google/chromeec: Add debug timestamp for host EC commands
......................................................................
Patch Set 18: Code-Review+1
(1 comment)
File src/ec/google/chromeec/Kconfig:
https://review.coreboot.org/c/coreboot/+/85326/comment/57c60946_3154588a?usp... :
PS18, Line 101: depends on EC_GOOGLE_CHROMEEC_LPC
nit: this feature depends on presence of monotonic timer, please consider adding `depends on HAVE_MONOTONIC_TIMER`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85326?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8ab89830ede940d2237ad21187b137dca9689fb0
Gerrit-Change-Number: 85326
Gerrit-PatchSet: 18
Gerrit-Owner: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 06 Jan 2025 17:48:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes