Attention is currently required from: Julius Werner, Angel Pons, Patrick Rudolph. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59008 )
Change subject: mb/google,samsung: Drop init_bootmode_straps() ......................................................................
Patch Set 4:
(2 comments)
File src/include/bootmode.h:
https://review.coreboot.org/c/coreboot/+/59008/comment/6c9bc34c_66d76042 PS2, Line 19: void stash_bootmode(int flag_spi_wp, int flag_rec_mode);
IIRC our official instructions to users have always been "hold down the recovery button until you se […]
Ack
File src/mainboard/google/beltino/chromeos.c:
https://review.coreboot.org/c/coreboot/+/59008/comment/413532be_62d6687d PS3, Line 16: !get_recovery_mode_switch(), "presence"},
In depthcharge, for GPIO_REC_MODE we only ever cared about the value that was sampled by coreboot -- […]
Well get_recovery_mode_switch() is sampled src/security/vboot/vboot_logic.c and the lb_gpio identifier string "presence" has no longer been placed there for ages.
So I was hoping to have a reason to drop any remaining "presence" entries as superseded by vboot context.
-
Kyösti Mälkki (Code Review)