Attention is currently required from: Jason Glenesk, Raul Rangel, Jason Nien, Matt DeVillier, Martin Roth, Fred Reitberger, Felix Held.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67189 )
Change subject: soc/amd: Throttle SOC during low/no battery
......................................................................
Patch Set 9:
(2 comments)
File src/mainboard/google/skyrim/variants/skyrim/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/67189/comment/f91d2a32_227859ba
PS5, Line 234: # Normal
No one is setting `dptc_enable`, so we don't have to worry about writing incorrect data.
...
Having the different CLs will make it easier to bisect and blame any regressions.
As you point out, there's nothing to bisect here, so there's no benefit to breaking this CL apart. There is no executable code, so there's nothing to regress aside from build errors which already give a line number.
Regardless, in the interest of trying to move these CLs forward I've split this into another CL.
File src/soc/amd/mendocino/chip.h:
https://review.coreboot.org/c/coreboot/+/67189/comment/f83cee9d_83ce9be4
PS7, Line 68: vrm_current_limit_mA
Do we need to pass these into FSP as well? […]
I've validated that these values are applied using `agt`. Why would we need to pass these to FSP (what does adding these to `fsp_m_params.c` fix)?
@Felix - Any thoughts here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67189
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifeddb99e97af93b40a5aad960d760e4c101cf086
Gerrit-Change-Number: 67189
Gerrit-PatchSet: 9
Gerrit-Owner: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 06 Sep 2022 17:11:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment