Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84929?usp=email )
Change subject: soc/mediatek/mt8196: Add tracker driver ......................................................................
Patch Set 9:
(9 comments)
File src/soc/mediatek/common/include/soc/tracker_common.h:
https://review.coreboot.org/c/coreboot/+/84929/comment/b7e47066_00f51a44?usp... : PS9, Line 28: void tracker_dump_data(void); why is this necessary ?
https://review.coreboot.org/c/coreboot/+/84929/comment/2b166954_3b09438e?usp... : PS9, Line 30: #endif
`adding a line without newline at end of file`
Please fix.
File src/soc/mediatek/common/tracker.c:
https://review.coreboot.org/c/coreboot/+/84929/comment/ca0020af_979665df?usp... : PS9, Line 14: __weak why is this necessary ?
File src/soc/mediatek/mt8196/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/84929/comment/37da2971_4ac5ba77?usp... : PS9, Line 20: bootblock-y += tracker.c sort
File src/soc/mediatek/mt8196/bootblock.c:
https://review.coreboot.org/c/coreboot/+/84929/comment/82e3d435_fed202ab?usp... : PS9, Line 9: #include <soc/tracker_common.h> sort
File src/soc/mediatek/mt8196/tracker.c:
https://review.coreboot.org/c/coreboot/+/84929/comment/99d2fbed_39515aaf?usp... : PS9, Line 24: AR_TRACK_LOG_OFFSET move to next line
https://review.coreboot.org/c/coreboot/+/84929/comment/8b3e7570_5bdcc3ea?usp... : PS9, Line 25: one tab
https://review.coreboot.org/c/coreboot/+/84929/comment/f2a8833b_e29b2c36?usp... : PS9, Line 69: write32 write32p
https://review.coreboot.org/c/coreboot/+/84929/comment/e8525f09_2505ffb3?usp... : PS9, Line 96: read32 read32 p