[M] Change in coreboot[main]: payloads/external/Makefile.mk: build iPXE for EDK2 with custom boot o...

[Benjamin Doron (Code Review)]

Attention is currently required from: Felix Singer, Filip Lewiński, Krystian Hebel, Lean Sheng Tan, Maciej Pijanowski, Martin L Roth, Michał Kopeć, Michał Żygowski.

Benjamin Doron has posted comments on this change by Filip Lewiński. ( https://review.coreboot.org/c/coreboot/+/82721?usp=email )

Change subject: payloads/external/Makefile.mk: build iPXE for EDK2 with custom boot option name
......................................................................

Patch Set 5:

(1 comment)

File payloads/external/edk2/Makefile:

https://review.coreboot.org/c/coreboot/+/82721/comment/e876301f_c39d0a11?usp... :
PS3, Line 152: The Dasharo repository has the following additional options:
> > Could you follow the similar pattern from MrChromebox to create this kconfig (EDK2_REPO_DASHARO or […]

I agree. People add a feature here that's in their fork. If it's a fairly popular one though, it's bound to end up either upstreamed or cherry-picked. For example, secure boot is set as conditional to your fork, Matt, but we've upstreamed an implementation.

I'd really like to stop making features conditional on particular people's repos. The EDK2 buildsystem won't mind; if some build variable doesn't exist, it just continues. It might confuse users though, who will come running to all their different downstreams wondering why CSM doesn't work (I'm picking a fairly uncommon example for this, and I know that I haven't upstreamed my old implementation, nor 3mdeb their AMD-compatible one).