Attention is currently required from: Angel Pons, Michael Niewöhner, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58925 )
Change subject: soc/intel: move SGX ACPI code to block/acpi
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
File src/soc/intel/common/block/acpi/sgx.c:
https://review.coreboot.org/c/coreboot/+/58925/comment/d2966bdd_021b9da4
PS3, Line 6: #include <cpu/x86/msr.h>
I don't see anything about MSR in the code?
https://review.coreboot.org/c/coreboot/+/58925/comment/fa56d52b_5a00f23f
PS3, Line 8: #include <intelblocks/msr.h>
I don't see anything about MSR in the code?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58925
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I089d0ee97c37df2be060b5996183201bfa9b49ca
Gerrit-Change-Number: 58925
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 07 Nov 2021 17:50:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment