Change in coreboot[master]: drivers/intel/fsp1_1/raminit.c: Always check FSP HOBs - coreboot-gerrit

3 Aug 2019


      Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29371 )
Change subject: drivers/intel/fsp1_1/raminit.c: Always check FSP HOBs
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/29371/11/src/drivers/intel/fsp1_1/r... 
File src/drivers/intel/fsp1_1/raminit.c:
https://review.coreboot.org/c/coreboot/+/29371/11/src/drivers/intel/fsp1_1/r... 
PS11, Line 264: && CONFIG(DISPLAY_HOBS))
this shouldn't have been added, no relation to HOB display and breaks MRC cache on all FSP 1.1 devices when CONFIG_DISPLAY_HOBS isn't selected. Fixed in CB:34685
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29371
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3776fa37866c7ef3aea090842387660c22bbdd4d
Gerrit-Change-Number: 29371
Gerrit-PatchSet: 11
Gerrit-Owner: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Huang Jin huang.jin@intel.com
Gerrit-Reviewer: Lee Leahy leroy.p.leahy@intel.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Piotr Król piotr.krol@3mdeb.com
Gerrit-Reviewer: York Yang yyang024@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: David Hendricks david.hendricks@gmail.com
Gerrit-CC: Matt DeVillier matt.devillier@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 03 Aug 2019 03:49:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment