Attention is currently required from: Furquan Shaikh, Felix Held. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51675 )
Change subject: mb/google/guybrush: Update GPIO configuration ......................................................................
Patch Set 11:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51675/comment/5adfce04_17db3e65 PS10, Line 9: Init I2C3 early for GSC communication.
This isn't done as part of this CL.
Done
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/51675/comment/cf09620e_733a7a04 PS10, Line 59: // PAD_NF(GPIO_26, PCIE_RST_L, PULL_NONE),
I think it's best not to leave commented out code here. […]
Done
https://review.coreboot.org/c/coreboot/+/51675/comment/f084ea59_6f706890 PS10, Line 180: SPI_CLK2
nit: Probably name this ESPI_SOC_CLK? That will make it clear that this is related to eSPI clock.
Done, here and above.
-
Martin Roth (Code Review)