Change in ...coreboot[master]: nb/intel/snb: Don't run VGA oprom when libgfxinit is enabled

[Nico Huber (Code Review)]

Hello Julius Werner, Angel Pons, Arthur Heymans,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/33126

to review the following change.

Change subject: nb/intel/snb: Don't run VGA oprom when libgfxinit is enabled
......................................................................

nb/intel/snb: Don't run VGA oprom when libgfxinit is enabled

This was likely an oversight when libgfxinit got its own Kconfig
symbols.

Change-Id: I647551719b332b5b734720ae4ee0619bbfcbed8c
Signed-off-by: Nico Huber 
---
M src/northbridge/intel/sandybridge/gma.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/33126/1

diff --git a/src/northbridge/intel/sandybridge/gma.c b/src/northbridge/intel/sandybridge/gma.c
index 1005288..19df8d4 100644
--- a/src/northbridge/intel/sandybridge/gma.c
+++ b/src/northbridge/intel/sandybridge/gma.c
@@ -626,7 +626,7 @@
    /* Init graphics power management */
    gma_pm_init_pre_vbios(dev);

-	if (!CONFIG(MAINBOARD_DO_NATIVE_VGA_INIT))
+	if (!CONFIG(MAINBOARD_USE_LIBGFXINIT))
    	/* PCI Init, will run VBIOS */
    	pci_dev_init(dev);

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33126 )

Change subject: nb/intel/snb: Don't run VGA oprom when libgfxinit is enabled
......................................................................

Patch Set 1: Code-Review+2

[Nico Huber (Code Review)]

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33126 )

Change subject: nb/intel/snb: Don't run VGA oprom when libgfxinit is enabled
......................................................................

nb/intel/snb: Don't run VGA oprom when libgfxinit is enabled

This was likely an oversight when libgfxinit got its own Kconfig
symbols.

Change-Id: I647551719b332b5b734720ae4ee0619bbfcbed8c
Signed-off-by: Nico Huber 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33126
Reviewed-by: Arthur Heymans 
Tested-by: build bot (Jenkins) 
---
M src/northbridge/intel/sandybridge/gma.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Arthur Heymans: Looks good to me, approved

diff --git a/src/northbridge/intel/sandybridge/gma.c b/src/northbridge/intel/sandybridge/gma.c
index 1005288..19df8d4 100644
--- a/src/northbridge/intel/sandybridge/gma.c
+++ b/src/northbridge/intel/sandybridge/gma.c
@@ -626,7 +626,7 @@
    /* Init graphics power management */
    gma_pm_init_pre_vbios(dev);

-	if (!CONFIG(MAINBOARD_DO_NATIVE_VGA_INIT))
+	if (!CONFIG(MAINBOARD_USE_LIBGFXINIT))
    	/* PCI Init, will run VBIOS */
    	pci_dev_init(dev);