Change in ...coreboot[master]: drivers/intel/gma: Choose better default settings for HSW
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31465
Change subject: drivers/intel/gma: Choose better default settings for HSW ......................................................................
drivers/intel/gma: Choose better default settings for HSW
When libgfxinit was added, there were no Haswell boards in the tree with discrete CPU/PCH. There are now, and we have a Kconfig to distingush them. So use that instead of mainboard overrides.
TEST=Built config for asrock/h81m-hds and checked that GFX_GMA_CPU_VARIANT is still set to `Normal`.
Change-Id: I5e54176e235e43ca28e4baf43dbb9860e7fc3dbd Signed-off-by: Nico Huber nico.huber@secunet.com --- M src/drivers/intel/gma/Kconfig M src/mainboard/asrock/h81m-hds/Kconfig 2 files changed, 1 insertion(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/31465/1
diff --git a/src/drivers/intel/gma/Kconfig b/src/drivers/intel/gma/Kconfig index 2dbed01..fd2422d 100644 --- a/src/drivers/intel/gma/Kconfig +++ b/src/drivers/intel/gma/Kconfig @@ -105,7 +105,7 @@ default "ULT" if ((SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEY_LAKE) \ && !SOC_INTEL_CANNONLAKE_PCH_H) \ || ((SOC_INTEL_SKYLAKE || SOC_INTEL_KABYLAKE) && !SKYLAKE_SOC_PCH_H) \ - || SOC_INTEL_BROADWELL || NORTHBRIDGE_INTEL_HASWELL + || SOC_INTEL_BROADWELL || (NORTHBRIDGE_INTEL_HASWELL && INTEL_LYNXPOINT_LP) default "Normal"
config GFX_GMA_INTERNAL_PORT diff --git a/src/mainboard/asrock/h81m-hds/Kconfig b/src/mainboard/asrock/h81m-hds/Kconfig index 55f1637..f2ba55c 100644 --- a/src/mainboard/asrock/h81m-hds/Kconfig +++ b/src/mainboard/asrock/h81m-hds/Kconfig @@ -40,14 +40,6 @@ hex default 0x200000
-# -# The override of GFX_GMA_CPU_VARIANT should be removed once the patches -# for dynamic CPU detection are merged in libgfxinit. -# -config GFX_GMA_CPU_VARIANT - string - default "Normal" - config MAINBOARD_DIR string default asrock/h81m-hds
Duncan Laurie has uploaded a new patch set (#2) to the change originally created by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/31465 )
Change subject: drivers/intel/gma: Choose better default settings for HSW ......................................................................
drivers/intel/gma: Choose better default settings for HSW
When libgfxinit was added, there were no Haswell boards in the tree with discrete CPU/PCH. There are now, and we have a Kconfig to distingush them. So use that instead of mainboard overrides.
TEST=Built config for asrock/h81m-hds and checked that GFX_GMA_CPU_VARIANT is still set to `Normal`.
Change-Id: I5e54176e235e43ca28e4baf43dbb9860e7fc3dbd Signed-off-by: Nico Huber nico.huber@secunet.com --- M src/drivers/intel/gma/Kconfig M src/mainboard/asrock/h81m-hds/Kconfig 2 files changed, 1 insertion(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/31465/2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31465 )
Change subject: drivers/intel/gma: Choose better default settings for HSW ......................................................................
Patch Set 2: Code-Review+2
Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31465 )
Change subject: drivers/intel/gma: Choose better default settings for HSW ......................................................................
Patch Set 2: Code-Review+2
Hello Patrick Rudolph, Tristan Corrick, Duncan Laurie, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31465
to look at the new patch set (#3).
Change subject: mb/asrock/h81m-hds: Drop now obsolete libgfxinit override ......................................................................
mb/asrock/h81m-hds: Drop now obsolete libgfxinit override
CPU type is detected at runtime now.
Change-Id: I5e54176e235e43ca28e4baf43dbb9860e7fc3dbd Signed-off-by: Nico Huber nico.huber@secunet.com --- M src/mainboard/asrock/h81m-hds/Kconfig 1 file changed, 0 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/31465/3
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31465 )
Change subject: mb/asrock/h81m-hds: Drop now obsolete libgfxinit override ......................................................................
Patch Set 3: Code-Review+2
Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31465 )
Change subject: mb/asrock/h81m-hds: Drop now obsolete libgfxinit override ......................................................................
Patch Set 3: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31465 )
Change subject: mb/asrock/h81m-hds: Drop now obsolete libgfxinit override ......................................................................
mb/asrock/h81m-hds: Drop now obsolete libgfxinit override
CPU type is detected at runtime now.
Change-Id: I5e54176e235e43ca28e4baf43dbb9860e7fc3dbd Signed-off-by: Nico Huber nico.huber@secunet.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/31465 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org Reviewed-by: Tristan Corrick tristan@corrick.kiwi --- M src/mainboard/asrock/h81m-hds/Kconfig 1 file changed, 0 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved Tristan Corrick: Looks good to me, approved
diff --git a/src/mainboard/asrock/h81m-hds/Kconfig b/src/mainboard/asrock/h81m-hds/Kconfig index db2768d..928a010 100644 --- a/src/mainboard/asrock/h81m-hds/Kconfig +++ b/src/mainboard/asrock/h81m-hds/Kconfig @@ -40,14 +40,6 @@ hex default 0x200000
-# -# The override of GFX_GMA_CPU_VARIANT should be removed once the patches -# for dynamic CPU detection are merged in libgfxinit. -# -config GFX_GMA_CPU_VARIANT - string - default "Normal" - config MAINBOARD_DIR string default asrock/h81m-hds
-
Duncan Laurie (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)
-
Tristan Corrick (Code Review)