Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50600 )
Change subject: soc/amd/cezanne: always add S0i3 firmware part to amdfw
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50600/comment/9d8f3f57_abe8be77
PS3, Line 10: operation mode, but goes into recovery mode instead.
Is that a PSP firmware bug?
unsure, but probably not. we weren't adding one component it needs to operate properly and it was mostly by luck that we didn't run into issues caused by that until a few days ago. we were basically operating it out of spec (if there's some proper spec on which component it really needs; not sure about that tbh) and it complained about that which made us run into asserts in fsp which will probably also have caused some other malfunctions we'd be running into later
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50600
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If13b5495e9f246afd0317daaa53c3d2cefbaa4dc
Gerrit-Change-Number: 50600
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Justin Frodsham
justin.frodsham@protonmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 14 Feb 2021 18:32:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment