Change in ...coreboot[master]: mainboard/intel/strago/acpi: Method _CRS must be Serialized
Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32468
Change subject: mainboard/intel/strago/acpi: Method _CRS must be Serialized ......................................................................
mainboard/intel/strago/acpi: Method _CRS must be Serialized
IASL reports warning 'Control Method should be made Serialized'. Change _CRS method to Serialized.
BUG=N/A TEST=Build Intel Strago
Change-Id: I63a7e1caab19360a9a5831458311d5a83fdf52d1 Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/intel/strago/acpi/mainboard.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/32468/1
diff --git a/src/mainboard/intel/strago/acpi/mainboard.asl b/src/mainboard/intel/strago/acpi/mainboard.asl index 68ac133..1d5437b 100644 --- a/src/mainboard/intel/strago/acpi/mainboard.asl +++ b/src/mainboard/intel/strago/acpi/mainboard.asl @@ -74,7 +74,7 @@ Name (_UID, 5) Name (ISTP, 0) /* TouchScreen */
- Method(_CRS, 0x0, NotSerialized) + Method(_CRS, 0x0, Serialized) { Name (BUF0, ResourceTemplate () { @@ -120,7 +120,7 @@ Name (_DDN, AUDIO_CODEC_DDN) Name (_UID, 1)
- Method(_CRS, 0x0, NotSerialized) + Method(_CRS, 0x0, Serialized) { Name(SBUF,ResourceTemplate () {
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32468 )
Change subject: mainboard/intel/strago/acpi: Method _CRS must be Serialized ......................................................................
Patch Set 2: Code-Review+2
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32468
to look at the new patch set (#3).
Change subject: mainboard/intel/strago/acpi: Serialize _CRS method ......................................................................
mainboard/intel/strago/acpi: Serialize _CRS method
IASL reports warning 'Control Method should be made Serialized'. Change _CRS method to Serialized.
BUG=N/A TEST=Build Intel Strago
Change-Id: I63a7e1caab19360a9a5831458311d5a83fdf52d1 Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/intel/strago/acpi/mainboard.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/32468/3
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32468 )
Change subject: mainboard/intel/strago/acpi: Serialize _CRS method ......................................................................
mainboard/intel/strago/acpi: Serialize _CRS method
IASL reports warning 'Control Method should be made Serialized'. Change _CRS method to Serialized.
BUG=N/A TEST=Build Intel Strago
Change-Id: I63a7e1caab19360a9a5831458311d5a83fdf52d1 Signed-off-by: Frans Hendriks fhendriks@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32468 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org --- M src/mainboard/intel/strago/acpi/mainboard.asl 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/mainboard/intel/strago/acpi/mainboard.asl b/src/mainboard/intel/strago/acpi/mainboard.asl index 68ac133..1d5437b 100644 --- a/src/mainboard/intel/strago/acpi/mainboard.asl +++ b/src/mainboard/intel/strago/acpi/mainboard.asl @@ -74,7 +74,7 @@ Name (_UID, 5) Name (ISTP, 0) /* TouchScreen */
- Method(_CRS, 0x0, NotSerialized) + Method(_CRS, 0x0, Serialized) { Name (BUF0, ResourceTemplate () { @@ -120,7 +120,7 @@ Name (_DDN, AUDIO_CODEC_DDN) Name (_UID, 1)
- Method(_CRS, 0x0, NotSerialized) + Method(_CRS, 0x0, Serialized) { Name(SBUF,ResourceTemplate () {
-
Frans Hendriks (Code Review) -
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)