[S] Change in coreboot[main]: util/superiotool: reformat alternate dump output

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80004?usp=email )

(

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
 )Change subject: util/superiotool: reformat alternate dump output
......................................................................

util/superiotool: reformat alternate dump output

Reformat alternate dump output to show default values before read
values, and to use brackets to visually indicate which values differ
from the defaults.

old output:

Register dump:
idx   val    def
0x07: 0x0b   (0x00)
0x10: 0xff   (0xff)
0x11: 0xff   (0xff)
...

new output:

Register dump:
idx    def    val
0x07:  0x00  [0x0b]
0x10:  0xff   0xff
0x11:  0xff   0xff
...

TEST=build/dump registers from Erying SRMJ4 w/Nuvoton NCT6796D.

Change-Id: Idef2cc136151328b114620eb297ab8fd62b71bcd
Signed-off-by: Matt DeVillier 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80004
Reviewed-by: Arthur Heymans 
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Menzel 
---
M util/superiotool/superiotool.c
1 file changed, 15 insertions(+), 8 deletions(-)

Approvals:
  Arthur Heymans: Looks good to me, approved
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve

diff --git a/util/superiotool/superiotool.c b/util/superiotool/superiotool.c
index 576e9e6..aee5026 100644
--- a/util/superiotool/superiotool.c
+++ b/util/superiotool/superiotool.c
@@ -107,25 +107,32 @@

if (alternate_dump) {
    	int skip_def = 0;
+		int val;

-		printf("\nidx   val    def\n");
+		printf("\nidx    def    val\n");

for (k = 0; idx[k] != EOT; k++) {
-			printf("0x%02x: 0x%02x", idx[k], regval(port, idx[k]));
-
    		if (skip_def || def[k] == EOT) {
    			skip_def = 1;
    			printf("\n");
    			continue;
    		}
+
+			printf("0x%02x:  ", idx[k]);
+			val = regval(port, idx[k]);
+
    		if (def[k] == NANA)
-				printf("   (NA)\n");
+				printf("(NA)   0x%02x\n", val);
    		else if (def[k] == RSVD)
-				printf("   (RR)\n");
+				printf("(RR)   0x%02x\n", val);
    		else if (def[k] == MISC)
-				printf("   (MM)\n");
-			else
-				printf("   (0x%02x)\n", def[k]);
+				printf("(MM)   0x%02x\n", val);
+			else {
+				if (def[k] == val)
+					printf("0x%02x   0x%02x\n", def[k], val);
+				else
+					printf("0x%02x  [0x%02x]\n", def[k], val);
+			}
    	}
    } else {
    	printf("\nidx");