Change in ...coreboot[master]: ec/lenovo/h8: Enable battery thresholds for more platforms, add bound...
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23177 )
Change subject: ec/lenovo/h8: Enable battery thresholds for more platforms, add boundary checks ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/23177/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/23177/1//COMMIT_MSG@7 PS1, Line 7: ec/lenovo/h8: Enable battery thresholds for more platforms, add boundary checks why do you add boundary checks ? Is there an OS that sets out of bounds values ?
https://review.coreboot.org/#/c/23177/1/src/ec/lenovo/h8/acpi/tp_acpi_bat_b0... File src/ec/lenovo/h8/acpi/tp_acpi_bat_b0.asl:
https://review.coreboot.org/#/c/23177/1/src/ec/lenovo/h8/acpi/tp_acpi_bat_b0... PS1, Line 41: if (Arg1 <= 100) { use tabs instead of space
-
Patrick Rudolph (Code Review)